From: Richard Earnshaw <rearnsha@arm.com>
To: Jie Zhang <jie@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Richard Henderson <rth@redhat.com>
Subject: Re: [ARM] Remove register constraints from push multiple patterns (was Re: [PATCH] Provide a hook for target to disable register renaming for some instructions)
Date: Thu, 01 Jul 2010 13:38:00 -0000 [thread overview]
Message-ID: <1277991469.22174.30.camel@e102346-lin.cambridge.arm.com> (raw)
In-Reply-To: <4C2C95F5.9000000@codesourcery.com>
On Thu, 2010-07-01 at 21:19 +0800, Jie Zhang wrote:
> On 07/01/2010 02:03 AM, Richard Henderson wrote:
> > On 06/30/2010 10:53 AM, Jie Zhang wrote:
> >> When compiler an application for ARM, the GAS issued a warning:
> >>
> >> Warning: register range not in ascending order
> >>
> >> for the instruction
> >>
> >> push {ip, r3, r4, lr}
> >>
> >> Before regrename pass, this instruction looked like
> >>
> >> push {r0, r3, r4, lr}
> >
> > Doesn't it work just as well to simply remove the register
> > constraint from the push_multi instruction? Without that
> > the regrename pass won't get a register class for the
> > operand and will leave it alone.
> >
> According to Richard's comment, a new patch is attached. It removes
> register constraints from all three push multiple patterns. Since there
> are no constraints for operand 1 of *push_multi_vfp, I use a new
> predicate to make it more stricter.
>
> Tested on arm-none-eabi for NEON and non-NEON. No regressions found.
>
> Is it OK?
>
> Regards,
OK
R.
next prev parent reply other threads:[~2010-07-01 13:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-30 18:36 [PATCH] Provide a hook for target to disable register renaming for some instructions Jie Zhang
2010-06-30 18:45 ` Richard Henderson
2010-06-30 19:55 ` Jie Zhang
2010-07-01 13:20 ` [ARM] Remove register constraints from push multiple patterns (was Re: [PATCH] Provide a hook for target to disable register renaming for some instructions) Jie Zhang
2010-07-01 13:38 ` Richard Earnshaw [this message]
2010-07-03 16:44 ` Jie Zhang
2010-07-05 8:52 ` Richard Earnshaw
2010-07-05 12:47 ` Jie Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1277991469.22174.30.camel@e102346-lin.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jie@codesourcery.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).