From: Richard Earnshaw <rearnsha@arm.com>
To: Chung-Lin Tang <cltang@codesourcery.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, ARM] soft/hard-float preprocessor symbol
Date: Tue, 27 Jul 2010 16:35:00 -0000 [thread overview]
Message-ID: <1280248085.15573.24.camel@e102346-lin.cambridge.arm.com> (raw)
In-Reply-To: <4C4D168F.3080708@codesourcery.com>
On Mon, 2010-07-26 at 13:01 +0800, Chung-Lin Tang wrote:
> Richard Earnshaw wrote:
> > The tests should be on arm_pcs_default. If that has the value
> > ARM_PCS_AAPCS_VFP then __ARM_PCS_VFP should be defined. If it has the
> > value ARM_PCS_AAPCS, then __ARM_PCS should be defined. In other cases,
> > I think neither should be defined (leaving the option open to create new
> > pre-processor defines in future).
> >
> > That does leave nothing defined for the IWMMXT variant. I'm not
> > entirely sure what to do about that. It appears that this just follows
> > the base standard for calling, in which case __ARM_PCS probably should
> > be defined, but I want to think that case through further before making
> > that decision: there may be a subtlety that I've missed.
> >
> > R.
> Hi Richard, I have update the patch as you have suggested.
> Please see if this is okay.
This is OK, but it needs an updated changelog entry (covering the
changes to arm.c as well).
R.
>
> Thanks,
> Chung-Lin
>
>
> plain text document attachment (pcs2.diff)
> Index: arm.c
> ===================================================================
> --- arm.c (revision 162525)
> +++ arm.c (working copy)
> @@ -711,7 +711,7 @@
> the next function. */
> static int after_arm_reorg = 0;
>
> -static enum arm_pcs arm_pcs_default;
> +enum arm_pcs arm_pcs_default;
>
> /* For an explanation of these variables, see final_prescan_insn below. */
> int arm_ccfsm_state;
> Index: arm.h
> ===================================================================
> --- arm.h (revision 162525)
> +++ arm.h (working copy)
> @@ -94,7 +94,13 @@
> if (arm_arch_iwmmxt) \
> builtin_define ("__IWMMXT__"); \
> if (TARGET_AAPCS_BASED) \
> - builtin_define ("__ARM_EABI__"); \
> + { \
> + if (arm_pcs_default == ARM_PCS_AAPCS_VFP) \
> + builtin_define ("__ARM_PCS_VFP"); \
> + else if (arm_pcs_default == ARM_PCS_AAPCS) \
> + builtin_define ("__ARM_PCS"); \
> + builtin_define ("__ARM_EABI__"); \
> + } \
> } while (0)
>
> /* The various ARM cores. */
> @@ -1641,6 +1647,9 @@
> ARM_PCS_UNKNOWN
> };
>
> +/* Default procedure calling standard of current compilation unit. */
> +extern enum arm_pcs arm_pcs_default;
> +
> /* A C type for declaring a variable that is used as the first argument of
> `FUNCTION_ARG' and other related values. */
> typedef struct
next prev parent reply other threads:[~2010-07-27 16:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-07-21 16:06 Chung-Lin Tang
2010-07-22 22:32 ` Mark Mitchell
2010-07-23 21:47 ` Richard Earnshaw
2010-07-26 5:01 ` Chung-Lin Tang
2010-07-27 16:35 ` Richard Earnshaw [this message]
2010-07-28 15:49 ` Chung-Lin Tang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1280248085.15573.24.camel@e102346-lin.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=cltang@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).