public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* [ARM] Disable cstoredf4 for single precision VFP
@ 2010-08-10  5:57 Jie Zhang
  2010-08-12 17:00 ` Richard Earnshaw
  0 siblings, 1 reply; 3+ messages in thread
From: Jie Zhang @ 2010-08-10  5:57 UTC (permalink / raw)
  To: GCC Patches

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

When working on Cortex-M4, I got an ICE from GCC. This patch should fix 
it. Testing on Cortex-M4 board with "-mcpu=cortex-m4 -mfloat-abi=softfp 
-mfpu=fpv4-sp-d16" shows this patch fixes many FAILs.

Is it OK?


Regards,
-- 
Jie Zhang
CodeSourcery

[-- Attachment #2: gcc-arm-disable-cstoredf4-for-sp.diff --]
[-- Type: text/x-patch, Size: 626 bytes --]


	* config/arm/arm.md (cstoredf4): Only valid when
	!TARGET_VFP_SINGLE.

Index: config/arm/arm.md
===================================================================
--- config/arm/arm.md	(revision 163048)
+++ config/arm/arm.md	(working copy)
@@ -7417,7 +7417,7 @@
 	(match_operator:SI 1 "arm_comparison_operator"
 	 [(match_operand:DF 2 "s_register_operand" "")
 	  (match_operand:DF 3 "arm_float_compare_operand" "")]))]
-  "TARGET_32BIT && TARGET_HARD_FLOAT"
+  "TARGET_32BIT && TARGET_HARD_FLOAT && !TARGET_VFP_SINGLE"
   "emit_insn (gen_cstore_cc (operands[0], operands[1],
 			     operands[2], operands[3])); DONE;"
 )

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ARM] Disable cstoredf4 for single precision VFP
  2010-08-10  5:57 [ARM] Disable cstoredf4 for single precision VFP Jie Zhang
@ 2010-08-12 17:00 ` Richard Earnshaw
  2010-08-13  4:08   ` Jie Zhang
  0 siblings, 1 reply; 3+ messages in thread
From: Richard Earnshaw @ 2010-08-12 17:00 UTC (permalink / raw)
  To: Jie Zhang; +Cc: GCC Patches


On Tue, 2010-08-10 at 13:09 +0800, Jie Zhang wrote:
> When working on Cortex-M4, I got an ICE from GCC. This patch should fix 
> it. Testing on Cortex-M4 board with "-mcpu=cortex-m4 -mfloat-abi=softfp 
> -mfpu=fpv4-sp-d16" shows this patch fixes many FAILs.
> 
> Is it OK?
> 
> 
> Regards,

OK.

R.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [ARM] Disable cstoredf4 for single precision VFP
  2010-08-12 17:00 ` Richard Earnshaw
@ 2010-08-13  4:08   ` Jie Zhang
  0 siblings, 0 replies; 3+ messages in thread
From: Jie Zhang @ 2010-08-13  4:08 UTC (permalink / raw)
  To: Richard Earnshaw; +Cc: GCC Patches

On 08/13/2010 12:52 AM, Richard Earnshaw wrote:
>
> On Tue, 2010-08-10 at 13:09 +0800, Jie Zhang wrote:
>> When working on Cortex-M4, I got an ICE from GCC. This patch should fix
>> it. Testing on Cortex-M4 board with "-mcpu=cortex-m4 -mfloat-abi=softfp
>> -mfpu=fpv4-sp-d16" shows this patch fixes many FAILs.
>>
>> Is it OK?
>>
>>
>> Regards,
>
> OK.
>
Thanks. Committed on trunk.

-- 
Jie Zhang
CodeSourcery

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-08-13  1:44 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-08-10  5:57 [ARM] Disable cstoredf4 for single precision VFP Jie Zhang
2010-08-12 17:00 ` Richard Earnshaw
2010-08-13  4:08   ` Jie Zhang

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).