From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id 323D73858CDB for ; Mon, 26 Feb 2024 15:51:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 323D73858CDB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 323D73858CDB Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708962702; cv=none; b=Ap+FTp4diMwz0JNmkQCP8FlUA8nu8PB9XmBCGfvCW4JFpFBNxVojGCLQoJSRAvvidVLvD477v6IxiqgXMhKQ/mjf0LBtyN/ToUuwhWv1ScMVeRBd2PhIrzFHu47eNxCpXycEpHqNEgJ9F2cRbdbemRqsR60vnKEaIEoWw82hnrs= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1708962702; c=relaxed/simple; bh=A3/HIPjYWBxn/Of4O+m4p6ZGouY+6YBVVcesj0Ssj+4=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=fDYUKsOGB6OLWSeufpgDb7iqwIpHi1BKj1bZE5FxSfIYVouawxZsjxGMeRxsowFaW1YwZS1su1c2nIeRBXJjKn0S1lB98g17n2iLpsjw2q3c7XmJkgV8eEgKIxIBpNNLSIhm3ZOMPbvexFL4ES0GMf5zNe/eFcnnOVst0rdpAOg= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from knuth.suse.de (unknown [10.168.5.16]) by smtp-out1.suse.de (Postfix) with ESMTP id 03AB7225D9; Mon, 26 Feb 2024 15:51:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708962699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OgVKT/vgOdelFAYRJue5prdS5h/SzmZXvtDwIFP88jc=; b=EBy+THPfdjXCppN93ogSF1sgXVNjwGVjpl6rqem43vb2C01XPodmlkQotYOdW1HJE65PKk pAWhUz1DM3vJMYLZ0OdoFMlIGO4JTth3rQwaN/VNrFZ1Vliy5ObZlUCt0M8F+TpMu8X7rV HC6LmPdlMTh9ONjqZQy0KBjogWpod9k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708962699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OgVKT/vgOdelFAYRJue5prdS5h/SzmZXvtDwIFP88jc=; b=VsrFJf0HC3lzrw+dXFzOT0441oLNs9J5mVNskTxg6oaRdBvN56VdYP0YuuGUIspicd5hqV RyTEoE1hvQY0jLAw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1708962699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OgVKT/vgOdelFAYRJue5prdS5h/SzmZXvtDwIFP88jc=; b=EBy+THPfdjXCppN93ogSF1sgXVNjwGVjpl6rqem43vb2C01XPodmlkQotYOdW1HJE65PKk pAWhUz1DM3vJMYLZ0OdoFMlIGO4JTth3rQwaN/VNrFZ1Vliy5ObZlUCt0M8F+TpMu8X7rV HC6LmPdlMTh9ONjqZQy0KBjogWpod9k= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1708962699; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OgVKT/vgOdelFAYRJue5prdS5h/SzmZXvtDwIFP88jc=; b=VsrFJf0HC3lzrw+dXFzOT0441oLNs9J5mVNskTxg6oaRdBvN56VdYP0YuuGUIspicd5hqV RyTEoE1hvQY0jLAw== Received: by knuth.suse.de (Postfix, from userid 10510) id DB4923346ED; Mon, 26 Feb 2024 16:51:08 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by knuth.suse.de (Postfix) with ESMTP id D9D9F3346EC; Mon, 26 Feb 2024 16:51:08 +0100 (CET) Date: Mon, 26 Feb 2024 16:51:08 +0100 (CET) From: Michael Matz To: Jakub Jelinek cc: Richard Biener , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] tree-optimization/114074 - CHREC multiplication and undefined overflow In-Reply-To: Message-ID: <12937df3-5d06-dd50-9ebf-254a6e952080@suse.de> References: <83476.124022609150401789@us-mta-131.us.mimecast.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Authentication-Results: smtp-out1.suse.de; none X-Spam-Level: X-Spam-Score: -1.74 X-Spamd-Result: default: False [-1.74 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[3]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; NEURAL_HAM_LONG(-1.00)[-1.000]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-0.999]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_NO_TLS_LAST(0.10)[]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_COUNT_TWO(0.00)[2]; MID_RHS_MATCH_FROM(0.00)[]; BAYES_HAM(-0.54)[80.76%] X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Hello, On Mon, 26 Feb 2024, Jakub Jelinek wrote: > > Will update the patch, I think any improvement should be done > > to get_range_pos_neg (it's a bit odd in behavior for unsigned > > but I have only signed things incoming). > > For unsigned if it always returned 1, it would be quite useless, there would > be no point for the caller to call it in that case. Which seems to make sense for a function called ...pos_neg on unsigned types. I would expect calling it to be useless and always return "yep, non-negative, why did you ask?". Ciao, Michael.