From: Mike Stump <mikestump@comcast.net>
To: Thomas Preud'homme <thomas.preudhomme@foss.arm.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Bernd Schmidt <bschmidt@redhat.com>,
"Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
Ramana Radhakrishnan <ramana.radhakrishnan@arm.com>
Subject: Re: [PATCH, testsuite] Fix g++.dg/pr67989.C test failure when running with -march or -mcpu
Date: Wed, 27 Jan 2016 20:04:00 -0000 [thread overview]
Message-ID: <12985F3F-71D1-4E44-8056-8106DE97E281@comcast.net> (raw)
In-Reply-To: <15470220.hO12rdEoa2@hardin.shanghai.arm.com>
On Jan 26, 2016, at 10:35 PM, Thomas Preud'homme <thomas.preudhomme@foss.arm.com> wrote:
> On Monday, January 18, 2016 11:33:47 AM Thomas Preud'homme wrote:
>> On Wednesday, January 13, 2016 06:39:20 PM Bernd Schmidt wrote:
>>> On 01/12/2016 08:55 AM, Thomas Preud'homme wrote:
>>>> On Monday, January 11, 2016 04:57:18 PM Bernd Schmidt wrote:
>>>>> On 01/08/2016 10:33 AM, Thomas Preud'homme wrote:
>>>>>> 2016-01-08 Thomas Preud'homme <thomas.preudhomme@arm.com>
>>>>>>
>>>>>> * g++.dg/pr67989.C: Remove ARM-specific option.
>>>>>> * gcc.target/arm/pr67989.C: New file.
>>>>>
>>>>> I checked some other arm tests and they have things like
>>>>>
>>>>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
>>>>> "-march=*" } { "-march=armv4t" } } */
>>>>> /* { dg-skip-if "avoid conflicting multilib options" { *-*-* } {
>>>>> "-mthumb" } { "" } } */
>>>>>
>>>>> Do you need the same in your testcase?
>>>>
>>>> That was the first approach I took but Kyrill suggested me to use
>>>> arm_arch_v4t and arm_arch_v4t_ok machinery instead. It should take care
>>>> about whether the architecture can be selected.
>>>
>>> Hmm, the ones I looked at did use dg-add-options, but not the
>>> corresponding _ok requirement. So I think this is OK.
>>
>> Just to make sure: ok as in OK to commit as is?
Ok.
prev parent reply other threads:[~2016-01-27 20:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-05 7:37 Thomas Preud'homme
2016-01-05 10:47 ` Kyrill Tkachov
2016-01-05 10:52 ` Richard Earnshaw (lists)
2016-01-05 10:56 ` Kyrill Tkachov
2016-01-07 7:35 ` Thomas Preud'homme
2016-01-07 9:15 ` Kyrill Tkachov
2016-01-07 10:26 ` Richard Earnshaw (lists)
2016-01-08 9:33 ` Thomas Preud'homme
2016-01-11 15:57 ` Bernd Schmidt
2016-01-12 7:55 ` Thomas Preud'homme
2016-01-13 17:39 ` Bernd Schmidt
2016-01-18 3:33 ` Thomas Preud'homme
2016-01-27 6:35 ` Thomas Preud'homme
2016-01-27 20:04 ` Mike Stump [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12985F3F-71D1-4E44-8056-8106DE97E281@comcast.net \
--to=mikestump@comcast.net \
--cc=Richard.Earnshaw@arm.com \
--cc=bschmidt@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=ramana.radhakrishnan@arm.com \
--cc=thomas.preudhomme@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).