From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by sourceware.org (Postfix) with ESMTPS id A9D813858D1E; Sun, 8 Oct 2023 13:07:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A9D813858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=fastmail.fm Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=fastmail.fm Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 000C55C024A; Sun, 8 Oct 2023 09:07:49 -0400 (EDT) Received: from imap44 ([10.202.2.94]) by compute3.internal (MEProxy); Sun, 08 Oct 2023 09:07:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.fm; h= cc:cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1696770469; x=1696856869; bh=OS2Z5W7bsHghweh/BooZ4/vwm2vHm8TT7yz zzqUGR1g=; b=YnDMU2TPzIkz6SUpuM0Jnd3X5hyzgaswTjWuCWP8npAHDb+LCsG 6ondzqLLXxTy6PCQ6fLjinIP/EAzAxQ8Ikock9WfQxwtaHg6R6PvChQOGeMznw/O 7hgPH2AvVeH9CWtgtewnHtudKOuK8O3nnGIPTjLIcDENmkypv64oR/LBnoKqnUkn f59JMJvuIF4AxjyqojLpLJNrms/k/Wa3flEA6MunHlGDl88ahm6bKvNbQZWFc4Hs /eODHCzf7BO9a/mQavT79pvjFcjNvUAU2ARBIx0U5SMWx1LxJlt17UN8QPQdzY/X tVDDJQ0JjtfX0mSKSTKthHyYRSOir6bUtUA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1696770469; x=1696856869; bh=OS2Z5W7bsHghweh/BooZ4/vwm2vHm8TT7yz zzqUGR1g=; b=gy6Y9zK0cuKfBz/QWqGCpNDsPEs8maLOhmtJxZEjcMhYUGRdcO1 Ipyvxct8etMu7vpBBxQXHiEYLpvxeYUlQ+3+xdivVeACR/em2CI83jNtpzKR/0Ij pH/6GjKYBr4yn3HkKeECjQWEcoiKux6hvKVd5UntWm4d8rh3FtH7Bef+9ssubHIl sYsnpmb81dHoemkbZoGbOZ37XhAuupLpwvpbsDx0oqb3K5mKvAJGJ5ntXn4+lsBN Pi/7kgTVVaVjudufyV3wR8W6B3dAgVSMl+9uV7g0Pz34VVIeaLok5Rcqv9N3FpW2 41VuBNMlTyKzWUVsZ8PDMTd7Px6fOC4nynA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvkedrhedugdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefofgggkfgjfhffhffvvefutgfgsehtqhertderreejnecuhfhrohhmpedfpfgr thhhrghnrggvlhcupfgvrhhouggvfdcuoehntghnpghgtggtuddtsehfrghsthhmrghilh drfhhmqeenucggtffrrghtthgvrhhnpeevgeehffeuudeftefgffefkedvjeetfffhtdei ieekgfevhfdvvdegueektdefudenucffohhmrghinhepghhnuhdrohhrghenucevlhhush htvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehntghnpghgtggtuddt sehfrghsthhmrghilhdrfhhm X-ME-Proxy: Feedback-ID: i49f641f0:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 81C0436A0075; Sun, 8 Oct 2023 09:07:49 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-958-g1b1b911df8-fm-20230927.002-g1b1b911d MIME-Version: 1.0 Message-Id: <129c7396-2aa4-4551-8e4c-291519f9b6ae@app.fastmail.com> In-Reply-To: References: <92993a50-9667-45da-a62-5089e7e052f8@codesourcery.com> <14111ba7-615b-b2e9-6fba-e7bee3728182@codesourcery.com> <9B1D2B19-B4EB-48B0-91EE-9AC33B392875@gmail.com> <2abef445-3ba3-7b8a-29e7-ba736592e325@codesourcery.com> <3CB9E78B-65BF-4706-B13B-01422C42830B@gmail.com> Date: Sun, 08 Oct 2023 09:07:28 -0400 From: "Nathanael Nerode" To: "FX Coudert" , "GCC Patches" Cc: "Joseph Myers" , "bonzini@gnu.org" , neroden@gcc.gnu.org, aoliva@gcc.gnu.org, Ralf.Wildenhues@gmx.de, "Iain Sandoe" Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FROM,KAM_SHORT,RCVD_IN_DNSWL_LOW,RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: I hope a global maintainer can step up. I've been on hiatus from GCC wo= rk for some years, and this was never my part of the build system anyway= -- and I don't use Darwin -- so I'm not qualified to review it. It loo= ks fine but it should be reviewed by someone who knows what they're doin= g. On Wed, Sep 20, 2023, at 9:52 AM, FX Coudert wrote: > ping**2 for a build maintainer or global maintainer to review, please > It restores testing on darwin >=3D 21, which is not currently working > > If no maintainer is available to review build system, could I get=20 > guidance on how to proceed further? > > Thanks, > FX > > >> Le 12 sept. 2023 =C3=A0 19:52, FX Coudert a =C3= =A9crit : >>=20 >> Hi build maintainers, >>=20 >> May I ping this series of patches for review? In particular, they all= ow to restore testing on darwin, which is currently broken with darwin >= =3D 21, due to DYLD_LIBRARY_PATH being systematically removed from the e= nvironment by system tools. >>=20 >> It has been tested for two years on darwin, and would allow to restor= e regular regtesting on that target. It is a big step to help prevent bu= gs being undetected on this port. >>=20 >> The patchset was okayed from the driver point of view, but we need a = build reviewer (or global reviewer) to okay those bits. Original present= ation of the patches: >>=20 >> ------ >> I=E2=80=99d like to post an updated and rebased version of Iain Sando= e=E2=80=99s patches for modern darwin, originally posted in November 202= 1: https://gcc.gnu.org/pipermail/gcc-patches/2021-November/584775.html >>=20 >> The rationale in that message is pretty much unchanged, and the patch= es have been since tested thoroughly on darwin (both Intel and ARM) for = almost two years now. We have been shipping Iain=E2=80=99s branch (inclu= ding these patches) since then in Homebrew and most other major distros = of GCC on Darwin. So I think it=E2=80=99s been very thoroughly tested. >>=20 >> The main comment that arose from review in the previous incarnation w= as the need to at least offer the libtool part of the patch to upstream,= in order to reduce in the long term the divergence between our version = and upstream. I have done so in https://savannah.gnu.org/patch/index.php= ?10385 >>=20 >> (I would also note that I have offered other suggestions of small sni= ppets that could be upstream in libtool for darwin, but have not receive= d much feedback for now: https://savannah.gnu.org/patch/?10371) >> ------ >>=20 >>=20 >> Thanks, >> FX >>=20 >>=20 >>=20 >>> Le 29 ao=C3=BBt 2023 =C3=A0 22:17, FX Coudert = a =C3=A9crit : >>>=20 >>>> I think a build machinery review is needed. >>>=20 >>> Thanks. CC=E2=80=99ing the relevant maintainers for review of the bu= ild part. >>> The driver part and the darwin-specific part are already okayed. >>>=20 >>> FX > > > Attachments: > * 0001-Driver-Provide-a-spec-to-insert-rpaths-for-compiler-.patch > * 0002-Darwin-Allow-for-configuring-Darwin-to-use-embedded-.patch > * 0003-Darwin-rpaths-Add-with-darwin-extra-rpath.patch > * 0004-Testsuite-allow-non-installed-testing-on-darwin.patch > * 0005-Doc-document-the-new-Darwin-options.patch