public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Martin Sebor <msebor@gmail.com>
To: "Jeff Law" <law@redhat.com>, "Martin Liška" <mliska@suse.cz>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix target attribute handling (PR c++/81355).
Date: Wed, 02 Aug 2017 19:56:00 -0000	[thread overview]
Message-ID: <12b87224-9920-0376-3fa7-8e5fb434a6b0@gmail.com> (raw)
In-Reply-To: <23407770-6fdc-614c-22b9-8782c4d0d01d@redhat.com>

On 08/02/2017 01:04 PM, Jeff Law wrote:
> On 07/28/2017 05:13 AM, Martin Liška wrote:
>> Hello.
>>
>> Following patch skips empty strings in 'target' attribute.
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>>
>> Ready to be installed?
>> Martin
>>
>> gcc/ChangeLog:
>>
>> 2017-07-13  Martin Liska  <mliska@suse.cz>
>>
>> 	PR c++/81355
>> 	* attribs.c (sorted_attr_string): Skip empty strings.
>>
>> gcc/testsuite/ChangeLog:
>>
>> 2017-07-13  Martin Liska  <mliska@suse.cz>
>>
>> 	PR c++/81355
>> 	* g++.dg/other/pr81355.C: New test.
> OK.  THough one could legitimately ask if this ought to be a parsing error.

I would suggest to at least issue a warning.  It seems that
the empty string must almost certainly be a bug here, say due
to unintended macro expansion.

Otherwise, if it should remain silently (and intentionally)
accepted, I recommend to document it.  As it is, the manual
says that the "string" argument is equivalent to compiling
with -mstring which for "" would be rejected by the driver.

Martin

  reply	other threads:[~2017-08-02 19:56 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-28 11:13 Martin Liška
2017-08-02 19:04 ` Jeff Law
2017-08-02 19:56   ` Martin Sebor [this message]
2017-08-08  4:59     ` [PATCH][v2] " Martin Liška
2017-08-08 16:36       ` Jason Merrill
2017-08-08 18:03       ` Martin Sebor
2017-08-09 10:45         ` Martin Liška
2017-08-09 19:44           ` Jason Merrill
2017-09-18 13:01 ` Backport fix: [PATCH] " Martin Liška
2017-09-18 13:06   ` Jakub Jelinek
2017-09-19  8:19     ` Martin Liška

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12b87224-9920-0376-3fa7-8e5fb434a6b0@gmail.com \
    --to=msebor@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    --cc=mliska@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).