From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by sourceware.org (Postfix) with ESMTPS id 5B8F33858432; Tue, 11 Jan 2022 07:27:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B8F33858432 Received: from pps.filterd (m0098399.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.1.2/8.16.1.2) with SMTP id 20B5s2OB027486; Tue, 11 Jan 2022 07:27:36 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3dfm6qeyb5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jan 2022 07:27:36 +0000 Received: from m0098399.ppops.net (m0098399.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.43/8.16.0.43) with SMTP id 20B5l9LH002513; Tue, 11 Jan 2022 07:27:35 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 3dfm6qeya9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jan 2022 07:27:35 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 20B7IXDj003886; Tue, 11 Jan 2022 07:27:33 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma04ams.nl.ibm.com with ESMTP id 3df288uj1d-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 11 Jan 2022 07:27:33 +0000 Received: from d06av26.portsmouth.uk.ibm.com (d06av26.portsmouth.uk.ibm.com [9.149.105.62]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 20B7RUYG42860828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 11 Jan 2022 07:27:30 GMT Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 589A0AE053; Tue, 11 Jan 2022 07:27:30 +0000 (GMT) Received: from d06av26.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1C8ACAE058; Tue, 11 Jan 2022 07:27:28 +0000 (GMT) Received: from [9.197.252.59] (unknown [9.197.252.59]) by d06av26.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Tue, 11 Jan 2022 07:27:27 +0000 (GMT) Message-ID: <12c00770-755f-1477-aee9-cb8d11396902@linux.ibm.com> Date: Tue, 11 Jan 2022 15:27:25 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.4.1 Subject: Re: Ping: [PATCH] rs6000: Add split pattern to replace Content-Language: en-US To: David Edelsohn , Segher Boessenkool Cc: GCC Patches , Bill Schmidt , guojiufu , linkw@gcc.gnu.org References: <20211229012740.3245971-1-luoxhu@linux.ibm.com> <12753f54-0098-76d2-91ff-fe3526f4ac6f@linux.ibm.com> From: Xionghu Luo In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-ORIG-GUID: pMGlyzzmi_JpECTdavo2QfDesuJeRKb4 X-Proofpoint-GUID: RFolP-UGF2ZSbeG-e-nxPvyMi9G5QXQv X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.790,Hydra:6.0.425,FMLib:17.11.62.513 definitions=2022-01-11_02,2022-01-10_02,2021-12-02_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 impostorscore=0 lowpriorityscore=0 mlxscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2110150000 definitions=main-2201110037 X-Spam-Status: No, score=-4.8 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Jan 2022 07:27:38 -0000 On 2022/1/11 06:55, David Edelsohn wrote: >>> +(define_insn_and_split "sldoi_to_mov_" > It would be more consistent with the naming convention to use > "sldoi_to_mov" without the final "_". OK, thanks. > >>> + [(set (match_operand:VM 0 "altivec_register_operand") >>> + (unspec:VM [(match_operand:VM 1 "easy_vector_constant") > Should this be "easy_vector_constant_vsldoi"? This doesn't work. easy_vector_constant_vsldoi return false due to vspltis_shifted "return 0" as: vspltis_shifted (rtx op): /* If all elements are equal, we don't need to do VSLDOI. */ (gdb) p op $7 = (rtx_def *) (const_vector:V4SI [ (const_int 0 [0]) repeated x4 ]) (gdb) p easy_vector_constant_vsldoi(op, V4SImode) $8 = false p easy_vector_constant(op, V4SImode) $9 = true > >>> + (match_dup 1) >>> + (match_operand:VM 2 "u5bit_cint_operand")] > This should be match_operand:QI, right? Yes. > > Thanks, David > -- Thanks, Xionghu