From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x336.google.com (mail-wm1-x336.google.com [IPv6:2a00:1450:4864:20::336]) by sourceware.org (Postfix) with ESMTPS id B526F3858D3C; Fri, 2 Jun 2023 09:47:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B526F3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-3f6e13940daso18781805e9.0; Fri, 02 Jun 2023 02:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685699253; x=1688291253; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=D6Uhx9wFL7KdAA6L9Qp3nofo3tLL9x0IaIRnx0dCGQk=; b=iU9EBgBKufCeMHYgwsQ2S7slmEubqS1s9ymuyMVEhRjJLQKfbXzB2cPZm1sXfnVoGk dHJLh/pRe41QIVtNDhyBSZZ023WWKemN/IrahPFL/Sr01pVyj7eZlGr97wnKzFvrC8IP ALKMQfe8KRLQnMN8bF0NC5bwCmNdQF1wpoRq+J0kpfJLP8QwsivF0jxHZIFYpyLuJjmS 68sLPMsmomrmfGN4BLocG3YpxCGrMFolFyfXok+6g6cr1SjhWdZ9L4QYJF269hs0mTGT GxeAkgRYx0YszODcZXO9zrEt4KTcG1tLY8kh51Fw/HnXf/j9G5vdaX74dv/X9Y6+seMb whBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685699253; x=1688291253; h=in-reply-to:from:references:cc:to:content-language:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=D6Uhx9wFL7KdAA6L9Qp3nofo3tLL9x0IaIRnx0dCGQk=; b=apISU1pOWksV4BCFiNMV+FCFu4TxMZx1XxAfXXx456lk/0fPg3lfBTpkmgikkxbL5a BxG8J5bI1C4nGs50ECNFALwKZaW7FUrrNcyPzotMXllnCDZG7nNupHOs7CJcuPuGvoXe uoLMwylsDG63D/Ds/8/UijWKDkiEGQgPzyDNRp584/fJ5211ZwWXJBAQiaH38Cw6bu8e HPKsUKaJGTVVLeZAGDAi+fvlvRfukEbmxKUMOAK+9CGTqcMAiiL34ZjY/A4qH1JsAGip GWR1hB1QOndZd9BzlwHzU7CIz0pvi1NFiF708gJtEKaU4uEIolIlXA3nOav4jGi3ZnVJ Gi2A== X-Gm-Message-State: AC+VfDz2tMdizZtGCRnbNVEMblB1ccICUik+Ekq6MEHKW6jdAWsQxTDq MNYj+3E4Z6tLCMtBH1YoIZc= X-Google-Smtp-Source: ACHHUZ4CezsK1D/85UHbhpeTxdlmoW13K2caNzWb7RHfglfGZHsodI6k2BpapgZ8eFV9chLugX4Ufw== X-Received: by 2002:adf:ec0e:0:b0:309:3869:380e with SMTP id x14-20020adfec0e000000b003093869380emr4475708wrn.57.1685699253173; Fri, 02 Jun 2023 02:47:33 -0700 (PDT) Received: from ?IPV6:2a01:e0a:1dc:b1c0:a3d5:45bc:17b:2385? ([2a01:e0a:1dc:b1c0:a3d5:45bc:17b:2385]) by smtp.gmail.com with ESMTPSA id n8-20020a5d4c48000000b00301a351a8d6sm1156720wrt.84.2023.06.02.02.47.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 02 Jun 2023 02:47:32 -0700 (PDT) Content-Type: multipart/alternative; boundary="------------0Pd6Ctda5AR1kRwSAfvmfCWw" Message-ID: <12cad432-888f-6db7-152a-89c5a17e4ac8@gmail.com> Date: Fri, 2 Jun 2023 11:47:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH] Move std::search into algobase.h Content-Language: en-US To: Jonathan Wakely Cc: Jonathan Wakely , Rainer Orth , Jonathan Wakely via Gcc-patches , libstdc++ References: <01f2b9e7-14e8-12a7-c275-7e48e3bd94df@gmail.com> <8f43b613-f185-8e46-8fc6-02bc286125b5@gmail.com> From: =?UTF-8?Q?Fran=c3=a7ois_Dumont?= In-Reply-To: X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,HTML_MESSAGE,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------0Pd6Ctda5AR1kRwSAfvmfCWw Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Ok, push done. Even after full rebuild those tests are still UNRESOLVED on my system. Yes, I also noticed that I could remove this check. I'll propose it later. François On 02/06/2023 09:43, Jonathan Wakely wrote: > On Fri, 2 Jun 2023 at 08:33, François Dumont wrote: > > I haven't been able to reproduce so far. > > Here is however a patch that I think will fix the problem. At > least failing tests are UNRESOLVED on my system. > >     libstdc++: Fix broken _GLIBCXX_PARALLEL mode > >     Add missing include in . > > > This fixes the broken parallel mode. > > >     Detect availability of in tests needing it to make > them UNSUPPORTED >     rather than PASS when header is missing. > >     libstdc++-v3/ChangeLog: > >             * include/parallel/algobase.h: Include > . >             * testsuite/lib/libstdc++.exp > (check_effective_target_omp): New. >             * testsuite/17_intro/headers/c++2011/parallel_mode.cc: >             Add { dg-require-effective-target omp }. >             * testsuite/17_intro/headers/c++2014/parallel_mode.cc: > Likewise. >             * testsuite/17_intro/headers/c++2017/parallel_mode.cc: > Likewise. > > Ok to commit ? > > > Please just add the #include to parallel/algobase.h for now. > > The effective-target keyword seems reasonable, but "omp" is not a good > name. And if we add that dg-require-effective-target to those tests > then they don't need to repeat the check in the test itself: > #if __has_include() > > So please just add the #include and then we can revisit the > effective-target separately. > > > > On 01/06/2023 23:57, Jonathan Wakely wrote: >> On Thu, 1 Jun 2023, 21:37 François Dumont via Libstdc++, >> > wrote: >> >> Now I've install OMP and try to rebuild lib to reproduce the >> failure. >> >> >> You shouldn't need to install anything, just build gcc and don't >> configure it with --disable-libgomp >> > I haven't used --disable-libgomp. But maybe when I run configure > the 1st time it tried to detect OMP install and failed to find it > as I just installed it. > > > I don't know what you mean, because GCC doesn't depend on "OMP". GCC > includes its own OpenMP implementation, and installs its own libgomp > runtime library to support the -fopenmp flag. It doesn't depend on > anything else. > > Which OS are you testing on? > --------------0Pd6Ctda5AR1kRwSAfvmfCWw--