From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 3005C3858C50 for ; Wed, 30 Mar 2022 02:21:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3005C3858C50 Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-606-BCLvYdINMkuHKtCbgkPQCA-1; Tue, 29 Mar 2022 22:21:55 -0400 X-MC-Unique: BCLvYdINMkuHKtCbgkPQCA-1 Received: by mail-qt1-f199.google.com with SMTP id p6-20020a05622a00c600b002e1cb9508e8so16272652qtw.20 for ; Tue, 29 Mar 2022 19:21:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=1Q6BGgqQdhhlVzU5PbFHlAzB8GBwbeMHUeAbFy/RPxY=; b=xmaW++btW/aG2SZ4+/eDOhkzewkGWF/P61wPex1/CQsrjUhrROCDDoAfREcGlf5V5C UKX0lcur/vkC4BZpY+tmBDwZ0SowhhqwMxN6LEJ3dYRfjGBlGeVJePiGWSfOjQhg9Yi/ 1EQUSf6XJuzTmMso14bnHUzlNohE5Pv6rVsCD0a67fEAie+zgxuJoRFvows5yO7enAB7 xvO+QJqF8WmP0I1RHkvrj2nLBeX7jDVgO2p1nGcev7p/FNYihUFuDWAjs5fdfP/vP9bN 3JGTdeLT6DgmxXO/k0/PqqvLd3cvipy1P/rLqkkU2svUlnSYPWlj0AlNHUxnKHUK1Uo4 rAgw== X-Gm-Message-State: AOAM532Y5EX9Bwreuwf3YYwZ7YoOMCwo5RhaRsiDH1gQZQyK5ljCMsKY HNZt7m2LYXs/fin5k8OVA/JC8uaszv1wl/vAo6IC3mYWMenPlzhp+lbk7nHb0yh41MXhvwqpXWS Y3KcYXkwZY0Gw633mrw== X-Received: by 2002:a05:620a:269a:b0:680:a5c5:954e with SMTP id c26-20020a05620a269a00b00680a5c5954emr19973113qkp.468.1648606914762; Tue, 29 Mar 2022 19:21:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzQwJ8CsyIwXHSrrMaFFawq3GaqSs61IVyJu5y5ftGUJIGGiugaz20JRxEk0nA5E+iZDtGUNA== X-Received: by 2002:a05:620a:269a:b0:680:a5c5:954e with SMTP id c26-20020a05620a269a00b00680a5c5954emr19973103qkp.468.1648606914459; Tue, 29 Mar 2022 19:21:54 -0700 (PDT) Received: from [192.168.1.149] (130-44-159-43.s15913.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.159.43]) by smtp.gmail.com with ESMTPSA id v5-20020a05622a144500b002e1c7d027b1sm15683164qtx.66.2022.03.29.19.21.53 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Mar 2022 19:21:53 -0700 (PDT) Message-ID: <12d83e36-46a2-221c-4535-11025376bfd6@redhat.com> Date: Tue, 29 Mar 2022 22:21:47 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH] c-family: ICE with -Wconversion and A ?: B [PR101030] To: Marek Polacek , GCC Patches References: <20220329205321.90251-1-polacek@redhat.com> From: Jason Merrill In-Reply-To: <20220329205321.90251-1-polacek@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.4 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H5, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Mar 2022 02:21:59 -0000 On 3/29/22 16:53, Marek Polacek wrote: > This patch fixes a crash in conversion_warning on a null expression. > It is null because the testcase uses the GNU A ?: B extension. We > could also use op0 instead of op1 in this case, but it doesn't seem > to be necessary. I wonder why we don't represent the extension as SAVE_EXPR(A) ? SAVE_EXPR(A) : B so we don't hit this sort of problem. But the patch is OK. > Bootstrapped/regtested on x86_64-pc-linux-gnu, ok for trunk? > > PR c++/101030 > > gcc/c-family/ChangeLog: > > * c-warn.cc (conversion_warning) : Don't call > conversion_warning when OP1 is null. > > gcc/testsuite/ChangeLog: > > * g++.dg/ext/cond5.C: New test. > --- > gcc/c-family/c-warn.cc | 2 +- > gcc/testsuite/g++.dg/ext/cond5.C | 13 +++++++++++++ > 2 files changed, 14 insertions(+), 1 deletion(-) > create mode 100644 gcc/testsuite/g++.dg/ext/cond5.C > > diff --git a/gcc/c-family/c-warn.cc b/gcc/c-family/c-warn.cc > index 9025fc1c20e..f24ac5d0539 100644 > --- a/gcc/c-family/c-warn.cc > +++ b/gcc/c-family/c-warn.cc > @@ -1300,7 +1300,7 @@ conversion_warning (location_t loc, tree type, tree expr, tree result) > tree op1 = TREE_OPERAND (expr, 1); > tree op2 = TREE_OPERAND (expr, 2); > > - return (conversion_warning (loc, type, op1, result) > + return ((op1 && conversion_warning (loc, type, op1, result)) > || conversion_warning (loc, type, op2, result)); > } > > diff --git a/gcc/testsuite/g++.dg/ext/cond5.C b/gcc/testsuite/g++.dg/ext/cond5.C > new file mode 100644 > index 00000000000..a92f28998f9 > --- /dev/null > +++ b/gcc/testsuite/g++.dg/ext/cond5.C > @@ -0,0 +1,13 @@ > +// PR c++/101030 > +// { dg-do compile { target { c++11 } } } > +// { dg-options "-Wconversion" } > + > +template > +struct jj { > + int ii[N ?: 1]; > + char c = N ?: 1; // { dg-warning "conversion from .int. to .char. changes value from .300. to " } > +}; > + > +int main() { > + jj<300> kk; > +} > > base-commit: 69db6e7f4e1d07bf8f33e93a29139cc16c1e0a2f