From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22978 invoked by alias); 5 Apr 2011 12:55:57 -0000 Received: (qmail 22968 invoked by uid 22791); 5 Apr 2011 12:55:56 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (94.185.240.25) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 05 Apr 2011 12:55:50 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 05 Apr 2011 13:55:47 +0100 Received: from [10.1.67.34] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 5 Apr 2011 13:55:46 +0100 Subject: Re: [PATCH] cleanup gcse.c:canon_modify_mem_list From: Richard Earnshaw To: Nathan Froyd Cc: Jeff Law , gcc-patches@gcc.gnu.org In-Reply-To: <20110405123041.GG23480@codesourcery.com> References: <20110404014451.GA16239@nightcrawler> <4D9A0765.6020901@redhat.com> <20110405114440.GE23480@codesourcery.com> <1302006159.25036.12.camel@e102346-lin.cambridge.arm.com> <20110405123041.GG23480@codesourcery.com> Date: Tue, 05 Apr 2011 12:55:00 -0000 Message-Id: <1302008146.25036.15.camel@e102346-lin.cambridge.arm.com> Mime-Version: 1.0 X-MC-Unique: 111040513554705301 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00330.txt.bz2 On Tue, 2011-04-05 at 05:30 -0700, Nathan Froyd wrote: > On Tue, Apr 05, 2011 at 01:22:39PM +0100, Richard Earnshaw wrote: > > On Tue, 2011-04-05 at 04:44 -0700, Nathan Froyd wrote: > > > > nit; You're missing some whitespace here (after the VEC). > > >=20 > > > This doesn't seem to be a hard-and-fast policy; all of the VEC code I > > > remember writing or looking at recently has no spaces, and I checked = the > > > patch in on that basis. However, running grep indicates that we have= a > > > profusion of styles... > >=20 > > I think the style guide is quite clear on this: there should be a space > > there as Jeff says. The fact that some code has crept in with other > > styles doesn't make them right, or give justification for ignoring the > > style guide. >=20 > Would you like a patch for the hundreds of instances without spaces? >=20 > Certainly vec.h never uses spaces; I thought this was simply The Way > Things Were. >=20 > -Nathan >=20 IMO, rototils are generally pointless. If you are fixing code nearby then yes, fix the formatting issues. Otherwise, just don't exacerbate the problem, or we'll reach the point where a rototil really does become necessary. R.