From: Magnus Fromreide <magfr@lysator.liu.se>
To: Paolo Carlini <paolo.carlini@oracle.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>,
"Daniel Krügler" <daniel.kruegler@googlemail.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [v3] Re-implement is_constructible, add is_default_constructible, is_destructible, fix PR 48526
Date: Thu, 14 Apr 2011 08:33:00 -0000 [thread overview]
Message-ID: <1302769968.2207.1.camel@sara> (raw)
In-Reply-To: <4DA62832.6080004@oracle.com>
On Thu, 2011-04-14 at 00:48 +0200, Paolo Carlini wrote:
> Hi!
>
> over the last 2 days or so, Daniel Krugler - having filed in due course
> his Copyright Assignment - finally kindly contributed to the project
> shiny new std::is_constructible, std::is_default_constructible and
> std::is_destructible. Being his first contribution, I helped integrating
> the work in our existing <type_traits> infrastructure. As you can see, I
> also took the occasion to use the new logical helper traits elsewhere,
> add a few more tweaks (remove a rather redundant macro, at this point),
> and also add tests in areas where the testsuite was weak (particularly
> because for some time we could assume shared code was at least exercised
> by the tr1/ testsuite).
This is just a nit, but why do you remove the /// is_function comments?
/MF
next prev parent reply other threads:[~2011-04-14 8:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-13 22:49 Paolo Carlini
2011-04-14 8:33 ` Magnus Fromreide [this message]
2011-04-14 8:41 ` Paolo Carlini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302769968.2207.1.camel@sara \
--to=magfr@lysator.liu.se \
--cc=daniel.kruegler@googlemail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=paolo.carlini@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).