From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4572 invoked by alias); 14 Apr 2011 08:33:02 -0000 Received: (qmail 4527 invoked by uid 22791); 14 Apr 2011 08:32:58 -0000 X-SWARE-Spam-Status: No, hits=-1.9 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mail.lysator.liu.se (HELO mail.lysator.liu.se) (130.236.254.3) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 14 Apr 2011 08:32:51 +0000 Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id A585E40018; Thu, 14 Apr 2011 10:32:49 +0200 (CEST) Received: from [83.252.230.177] (c83-252-230-177.bredband.comhem.se [83.252.230.177]) (using SSLv3 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 5DC4B4000A; Thu, 14 Apr 2011 10:32:49 +0200 (CEST) Subject: Re: [v3] Re-implement is_constructible, add is_default_constructible, is_destructible, fix PR 48526 From: Magnus Fromreide To: Paolo Carlini Cc: libstdc++ , Daniel =?ISO-8859-1?Q?Kr=FCgler?= , "gcc-patches@gcc.gnu.org" In-Reply-To: <4DA62832.6080004@oracle.com> References: <4DA62832.6080004@oracle.com> Content-Type: text/plain; charset="ISO-8859-1" Date: Thu, 14 Apr 2011 08:33:00 -0000 Message-ID: <1302769968.2207.1.camel@sara> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01045.txt.bz2 On Thu, 2011-04-14 at 00:48 +0200, Paolo Carlini wrote: > Hi! > > over the last 2 days or so, Daniel Krugler - having filed in due course > his Copyright Assignment - finally kindly contributed to the project > shiny new std::is_constructible, std::is_default_constructible and > std::is_destructible. Being his first contribution, I helped integrating > the work in our existing infrastructure. As you can see, I > also took the occasion to use the new logical helper traits elsewhere, > add a few more tweaks (remove a rather redundant macro, at this point), > and also add tests in areas where the testsuite was weak (particularly > because for some time we could assume shared code was at least exercised > by the tr1/ testsuite). This is just a nit, but why do you remove the /// is_function comments? /MF