From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18488 invoked by alias); 29 Apr 2011 19:46:18 -0000 Received: (qmail 18480 invoked by uid 22791); 29 Apr 2011 19:46:17 -0000 X-SWARE-Spam-Status: No, hits=-1.4 required=5.0 tests=AWL,BAYES_00,SARE_SUB_ENC_UTF8,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from fencepost.gnu.org (HELO fencepost.gnu.org) (140.186.70.10) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 29 Apr 2011 19:46:04 +0000 Received: from eggs.gnu.org ([140.186.70.92]:43835) by fencepost.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QFtdb-000378-0J for gcc-patches@gnu.org; Fri, 29 Apr 2011 15:46:03 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QFtdZ-0005Ks-RB for gcc-patches@gnu.org; Fri, 29 Apr 2011 15:46:02 -0400 Received: from smtp121.iad.emailsrvr.com ([207.97.245.121]:50404) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QFtdZ-0005Km-PD for gcc-patches@gnu.org; Fri, 29 Apr 2011 15:46:01 -0400 Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp52.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id B27A224023F; Fri, 29 Apr 2011 15:45:59 -0400 (EDT) Received: from dynamic3.wm-web.iad.mlsrvr.com (dynamic3.wm-web.iad1a.rsapps.net [192.168.2.152]) by smtp52.relay.iad1a.emailsrvr.com (SMTP Server) with ESMTP id 8B36B24018E; Fri, 29 Apr 2011 15:45:59 -0400 (EDT) Received: from meta-innovation.com (localhost [127.0.0.1]) by dynamic3.wm-web.iad.mlsrvr.com (Postfix) with ESMTP id 633CB332006E; Fri, 29 Apr 2011 15:45:59 -0400 (EDT) Received: by www2.webmail.us (Authenticated sender: nicola.pero@meta-innovation.com, from: nicola.pero@meta-innovation.com) with HTTP; Fri, 29 Apr 2011 21:45:59 +0200 (CEST) Date: Fri, 29 Apr 2011 20:37:00 -0000 Subject: =?UTF-8?Q?Re:=20(build)=20Patch=20to=20fix=20cp/cfns.gperf=20building=20?= =?UTF-8?Q?issues?= From: "Nicola Pero" To: "Alexandre Oliva" Cc: "Mike Stump" , "gcc-patches@gnu.org" MIME-Version: 1.0 Content-Type: text/plain;charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Type: plain In-Reply-To: References: <1303485121.088925951@www2.webmail.us> <514AA7B6-0B41-42BD-B39B-71E9434E152D@comcast.net> <1303558468.699813970@www2.webmail.us> Message-ID: <1304106359.40316453@www2.webmail.us> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 207.97.245.121 X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg02359.txt.bz2 Alexandre thanks for the review :-) > -pedantic review: how about outputting to a temporary file (say > cp/cfns.hT) and only renaming to the intended name on success, so that, > if gperf crashes or we reboot part-way through it, we don't end up with > a partially-generated file that will seem to be up to date? It's a good suggestion. On the other hand, now that the rule is maintainer-only, and considering it's used once every few years, I wouldn't personally want to spend more time on it. ;-) Thanks