From: Richard Earnshaw <rearnsha@arm.com>
To: Michael Hope <michael.hope@linaro.org>
Cc: gcc-patches@gcc.gnu.org, patches@linaro.org
Subject: Re: [PATCH, ARM] fix PR pch/45979 regression on ARM
Date: Tue, 03 May 2011 12:52:00 -0000 [thread overview]
Message-ID: <1304427148.26002.15.camel@e102346-lin.cambridge.arm.com> (raw)
In-Reply-To: <BANLkTi=JozMFpMe5Ye-qRztsJx+d_h=mBw@mail.gmail.com>
On Mon, 2011-05-02 at 09:21 +1200, Michael Hope wrote:
> Linux 2.6.35 and later on ARM randomise the address space, breaking
> precompiled header support in GCC. The fix is to use the support in
> GCC for mmap()ing into a fixed, likely to be free address. The ARM
> memory map is modeled on the i386 so I used the same definition.
>
> Tested on trunk with a Ubuntu 2.6.35 kernel. Bootstraps OK and clears
> all of the PCH testsuite failures. Note that this change is
> equivalent to Mikael Pettersson's patch at:
> http://gcc.gnu.org/ml/gcc-patches/2010-10/msg02252.html
>
> OK for trunk?
>
OK.
R.
> -- Michael
>
> gcc/
>
> 2011-05-02 Michael Hope <michael.hope@linaro.org>
>
> PR pch/45979
> * config/host-linux.c (TRY_EMPTY_VM_SPACE): Define for
> __ARM_EABI__ hosts.
>
> diff --git a/gcc/config/host-linux.c b/gcc/config/host-linux.c
> index 47ce3ea..8b41685 100644
> --- a/gcc/config/host-linux.c
> +++ b/gcc/config/host-linux.c
> @@ -84,6 +84,8 @@
> # define TRY_EMPTY_VM_SPACE 0x60000000
> #elif defined(__mc68000__)
> # define TRY_EMPTY_VM_SPACE 0x40000000
> +#elif defined(__ARM_EABI__)
> +# define TRY_EMPTY_VM_SPACE 0x60000000
> #else
> # define TRY_EMPTY_VM_SPACE 0
> #endif
next prev parent reply other threads:[~2011-05-03 12:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-01 21:22 Michael Hope
2011-05-03 12:52 ` Richard Earnshaw [this message]
2011-05-05 13:57 ` Ramana Radhakrishnan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304427148.26002.15.camel@e102346-lin.cambridge.arm.com \
--to=rearnsha@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=michael.hope@linaro.org \
--cc=patches@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).