From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 10577 invoked by alias); 3 May 2011 12:52:49 -0000 Received: (qmail 10561 invoked by uid 22791); 3 May 2011 12:52:49 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (94.185.240.25) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 03 May 2011 12:52:34 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 03 May 2011 13:52:31 +0100 Received: from [10.1.67.34] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 3 May 2011 13:52:28 +0100 Subject: Re: [PATCH, ARM] fix PR pch/45979 regression on ARM From: Richard Earnshaw To: Michael Hope Cc: gcc-patches@gcc.gnu.org, patches@linaro.org In-Reply-To: References: Date: Tue, 03 May 2011 12:52:00 -0000 Message-Id: <1304427148.26002.15.camel@e102346-lin.cambridge.arm.com> Mime-Version: 1.0 X-MC-Unique: 111050313523104801 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00163.txt.bz2 On Mon, 2011-05-02 at 09:21 +1200, Michael Hope wrote: > Linux 2.6.35 and later on ARM randomise the address space, breaking > precompiled header support in GCC. The fix is to use the support in > GCC for mmap()ing into a fixed, likely to be free address. The ARM > memory map is modeled on the i386 so I used the same definition. >=20 > Tested on trunk with a Ubuntu 2.6.35 kernel. Bootstraps OK and clears > all of the PCH testsuite failures. Note that this change is > equivalent to Mikael Pettersson's patch at: > http://gcc.gnu.org/ml/gcc-patches/2010-10/msg02252.html >=20 > OK for trunk? >=20 OK. R. > -- Michael >=20 > gcc/ >=20 > 2011-05-02 Michael Hope >=20 > PR pch/45979 > * config/host-linux.c (TRY_EMPTY_VM_SPACE): Define for > __ARM_EABI__ hosts. >=20 > diff --git a/gcc/config/host-linux.c b/gcc/config/host-linux.c > index 47ce3ea..8b41685 100644 > --- a/gcc/config/host-linux.c > +++ b/gcc/config/host-linux.c > @@ -84,6 +84,8 @@ > # define TRY_EMPTY_VM_SPACE 0x60000000 > #elif defined(__mc68000__) > # define TRY_EMPTY_VM_SPACE 0x40000000 > +#elif defined(__ARM_EABI__) > +# define TRY_EMPTY_VM_SPACE 0x60000000 > #else > # define TRY_EMPTY_VM_SPACE 0 > #endif