From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 344 invoked by alias); 17 May 2011 16:08:09 -0000 Received: (qmail 328 invoked by uid 22791); 17 May 2011 16:08:07 -0000 X-SWARE-Spam-Status: No, hits=-2.4 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW X-Spam-Check-By: sourceware.org Received: from service87.mimecast.com (HELO service87.mimecast.com) (94.185.240.25) by sourceware.org (qpsmtpd/0.43rc1) with SMTP; Tue, 17 May 2011 16:07:53 +0000 Received: from cam-owa1.Emea.Arm.com (fw-tnat.cambridge.arm.com [217.140.96.21]) by service87.mimecast.com; Tue, 17 May 2011 17:07:50 +0100 Received: from [10.1.67.34] ([10.1.255.212]) by cam-owa1.Emea.Arm.com with Microsoft SMTPSVC(6.0.3790.0); Tue, 17 May 2011 17:07:52 +0100 Subject: Re: Libiberty: POSIXify psignal definition From: Richard Earnshaw To: DJ Delorie Cc: vinschen@redhat.com, gcc-patches@gcc.gnu.org In-Reply-To: <201105171552.p4HFq4ch009720@greed.delorie.com> References: <20110505073039.GA23122@calimero.vinschen.de> <1305646410.29122.21.camel@e102346-lin.cambridge.arm.com> <201105171552.p4HFq4ch009720@greed.delorie.com> Date: Tue, 17 May 2011 19:34:00 -0000 Message-Id: <1305648468.29122.25.camel@e102346-lin.cambridge.arm.com> Mime-Version: 1.0 X-MC-Unique: 111051717075004901 Content-Type: text/plain; charset=WINDOWS-1252 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01233.txt.bz2 On Tue, 2011-05-17 at 11:52 -0400, DJ Delorie wrote: > > > * strsignal.c (psignal): Change second parameter to const char *. > > > Fix comment accordingly. > > >=20 > >=20 > > OK. >=20 > I had argued against this patch: >=20 > http://gcc.gnu.org/ml/gcc-patches/2011-05/msg00439.html >=20 > The newlib change broke ALL released versions of gcc, and the above > patch does NOT fix the problem, but merely hides it until the next > time we trip over it. >=20 So regardless of whether the changes to newlib are a good idea or not, I think the fix to libiberty is still right. Posix says that psignal takes a const char *, and libiberty's implementation doesn't. That's just silly. I do agree that the newlib code should be tightened up, particularly in order to support older compilers; but that doesn't mean we shouldn't fix libiberty as well. R.