From: Steve Ellcey <sje@cup.hp.com>
To: Hans-Peter Nilsson <hp@bitrange.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [patch, testsuite] Fix g++.dg/opt/devirt2.C scanning, PR 48727
Date: Thu, 16 Jun 2011 20:49:00 -0000 [thread overview]
Message-ID: <1308256680.10986.95.camel@hpsje.cup.hp.com> (raw)
In-Reply-To: <alpine.BSF.2.00.1106151244380.43062@dair.pair.com>
On Wed, 2011-06-15 at 12:51 -0400, Hans-Peter Nilsson wrote:
> On Fri, 10 Jun 2011, Steve Ellcey wrote:
>
> > I will check in this testsuite fix as obvious if there are no objections.
>
> But... :)
> JFTR, if you want this to be really right, you should not xfail
> this part of the test but rather skip it, as the test is at
> fault, not the targets/gcc. If think it'd be:
>
> // { dg-final { scan-assembler-times "xyzzy" 2 { target { ! { hppa*-*-* ia64*-*-* } } } } }
>
>
> > +// { dg-final { scan-assembler-times "br\[^\n\]*xyzzy" 2 { target ia64*-*-* } } }
> > +// { dg-final { scan-assembler-times "xyzzy\[^\n\]*,%r" 2 { target hppa*-*-* } } }
> >
> > struct S { S(); virtual void xyzzy(); };
> > struct R { int a; S s; R(); };
> >
>
> brgds, H-P
You are right, and I am going to check in this change as obvious.
I have tested it to make sure it works.
Steve Ellcey
sje@cup.hp.com
2011-06-16 Steve Ellcey <sje@cup.hp.com>
PR testsuite/48727
* g++.dg/opt/devirt2.C: Change xfail rule to target.
Index: g++.dg/opt/devirt2.C
===================================================================
--- g++.dg/opt/devirt2.C (revision 175089)
+++ g++.dg/opt/devirt2.C (working copy)
@@ -2,7 +2,7 @@
// { dg-options "-O2" }
// The IA64 and HPPA compilers generate external declarations in addition
// to the call so those scans need to be more specific.
-// { dg-final { scan-assembler-times "xyzzy" 2 { xfail hppa*-*-* ia64*-*-hpux* } } }
+// { dg-final { scan-assembler-times "xyzzy" 2 { target { ! { hppa*-*-* ia64*-*-hpux* } } } } }
// { dg-final { scan-assembler-times "br\[^\n\]*xyzzy" 2 { target ia64*-*-hpux* } } }
// { dg-final { scan-assembler-times "xyzzy\[^\n\]*,%r" 2 { target hppa*-*-* } } }
prev parent reply other threads:[~2011-06-16 20:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 17:09 Steve Ellcey
2011-06-11 17:53 ` Mike Stump
2011-06-15 17:15 ` Hans-Peter Nilsson
2011-06-16 20:49 ` Steve Ellcey [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308256680.10986.95.camel@hpsje.cup.hp.com \
--to=sje@cup.hp.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hp@bitrange.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).