* [patch, testsuite] Patch for gcc.dg/pr49994-3.c on HP-UX
@ 2011-10-20 17:32 Steve Ellcey
2011-10-20 17:42 ` Rainer Orth
0 siblings, 1 reply; 3+ messages in thread
From: Steve Ellcey @ 2011-10-20 17:32 UTC (permalink / raw)
To: gcc-patches
I am going to check this change in as obvious later today if there are
no objections, the test gives warnings on HP-UX because it calls
__builtin_return_address with arguments of 0 through 5 but the value 0
is the only valid argument to __builtin_return_address on HP-UX.
Tested on IA64 and PA HP-UX.
Steve Ellcey
sje@cup.hp.com
2011-10-20 Steve Ellcey <sje@cup.hp.com>
PR testsuite/50722
* gcc.dg/pr49994-3.c: Skip on HP-UX.
Index: gcc.dg/pr49994-3.c
===================================================================
--- gcc.dg/pr49994-3.c (revision 180233)
+++ gcc.dg/pr49994-3.c (working copy)
@@ -2,6 +2,7 @@
/* { dg-options "-O2 -fsched2-use-superblocks -g" } */
/* { dg-options "-O2 -fsched2-use-superblocks -g -mbackchain" { target s390*-*-* } } */
/* { dg-require-effective-target scheduling } */
+/* { dg-skip-if "" { *-*-hpux* } { "*" } { "" } } */
void *
foo (int offset)
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch, testsuite] Patch for gcc.dg/pr49994-3.c on HP-UX
2011-10-20 17:32 [patch, testsuite] Patch for gcc.dg/pr49994-3.c on HP-UX Steve Ellcey
@ 2011-10-20 17:42 ` Rainer Orth
2011-10-20 23:44 ` Steve Ellcey
0 siblings, 1 reply; 3+ messages in thread
From: Rainer Orth @ 2011-10-20 17:42 UTC (permalink / raw)
To: sje; +Cc: gcc-patches
Steve Ellcey <sje@cup.hp.com> writes:
> Index: gcc.dg/pr49994-3.c
> ===================================================================
> --- gcc.dg/pr49994-3.c (revision 180233)
> +++ gcc.dg/pr49994-3.c (working copy)
> @@ -2,6 +2,7 @@
> /* { dg-options "-O2 -fsched2-use-superblocks -g" } */
> /* { dg-options "-O2 -fsched2-use-superblocks -g -mbackchain" { target s390*-*-* } } */
> /* { dg-require-effective-target scheduling } */
> +/* { dg-skip-if "" { *-*-hpux* } { "*" } { "" } } */
Would you please include either an explanation or a PR reference in the
dg-skip-if? Having to search the archives for an explanation is tedious.
Btw., you should be able to omit both the "*" and "".
Thanks.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [patch, testsuite] Patch for gcc.dg/pr49994-3.c on HP-UX
2011-10-20 17:42 ` Rainer Orth
@ 2011-10-20 23:44 ` Steve Ellcey
0 siblings, 0 replies; 3+ messages in thread
From: Steve Ellcey @ 2011-10-20 23:44 UTC (permalink / raw)
To: Rainer Orth; +Cc: gcc-patches
On Thu, 2011-10-20 at 18:23 +0200, Rainer Orth wrote:
> Steve Ellcey <sje@cup.hp.com> writes:
>
> > Index: gcc.dg/pr49994-3.c
> > ===================================================================
> > --- gcc.dg/pr49994-3.c (revision 180233)
> > +++ gcc.dg/pr49994-3.c (working copy)
> > @@ -2,6 +2,7 @@
> > /* { dg-options "-O2 -fsched2-use-superblocks -g" } */
> > /* { dg-options "-O2 -fsched2-use-superblocks -g -mbackchain" { target s390*-*-* } } */
> > /* { dg-require-effective-target scheduling } */
> > +/* { dg-skip-if "" { *-*-hpux* } { "*" } { "" } } */
>
> Would you please include either an explanation or a PR reference in the
> dg-skip-if? Having to search the archives for an explanation is tedious.
>
> Btw., you should be able to omit both the "*" and "".
>
> Thanks.
> Rainer
I put "PR testsuite/50722" in the comment section and removed the "*"
and "" after verifying that it works and then checked in the change.
Steve Ellcey
sje@cup.hp.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-20 21:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-20 17:32 [patch, testsuite] Patch for gcc.dg/pr49994-3.c on HP-UX Steve Ellcey
2011-10-20 17:42 ` Rainer Orth
2011-10-20 23:44 ` Steve Ellcey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).