From: Torvald Riegel <triegel@redhat.com>
To: Andrew MacLeod <amacleod@redhat.com>
Cc: Benjamin Kosnik <bkoz@redhat.com>,
Hans-Peter Nilsson <hans-peter.nilsson@axis.com>,
joseph@codesourcery.com, gcc-patches@gcc.gnu.org,
libstdc++@gcc.gnu.org, rth@redhat.com
Subject: Re: cxx-mem-model merge [6 of 9] - libstdc++-v3
Date: Fri, 11 Nov 2011 23:34:00 -0000 [thread overview]
Message-ID: <1321053229.22674.41.camel@triegel.csb> (raw)
In-Reply-To: <4EBD5F27.9040005@redhat.com>
On Fri, 2011-11-11 at 12:45 -0500, Andrew MacLeod wrote:
> On 11/11/2011 12:43 AM, Benjamin Kosnik wrote:
> >
> >> bkoz: As relates to the existing problem, how is the legacy support
> >> invoked in compatibility-atomic-c++0x.cc? That has the old style
> >> implementation of atomic_flag with a lock, which would allow this
> >> target to compile... which is another option perhaps. or is that
> >> purely for pervious releases somehow?
> > compatibility-atomic-c++0x.cc is the support for previous builtins
> > attempt, let's call this atomics-try-2. We need to keep these symbols
> > exported and doing the same thing done in previous releases. (Or else
> > abi-check will fail.)
> >
> > If this system used to use a lock to work, then that is what it should
> > still do. The behavior shouldn't change.
> >
> I think there is also an argument for single threaded-ness vs multi
> threaded. If there is no atomic support and its single threaded, we
> don't really need the lock... and I'm not sure how you can detect the
> change in behaviour if test_and_set and clear just store 1 and 0 rather
> than create alock, then do the store of 1 or 0.
Also, if you're replacing it with atomic ops you can't see different
behavior because, well, they are atomic. However, this requires that
_nobody_ tries to synchronize using this lock anymore (only observing
the lock is fine, but you must never modify it). Likewise on a
single-threaded target.
Torvald
next prev parent reply other threads:[~2011-11-11 23:14 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 23:52 Andrew MacLeod
2011-11-04 18:17 ` Jeff Law
2011-11-04 18:53 ` Andrew MacLeod
2011-11-07 0:54 ` Hans-Peter Nilsson
2011-11-07 4:48 ` Andrew MacLeod
2011-11-07 11:36 ` Hans-Peter Nilsson
2011-11-07 14:41 ` Andrew MacLeod
2011-11-07 14:56 ` Andrew MacLeod
2011-11-07 15:38 ` Hans-Peter Nilsson
2011-11-07 16:28 ` Joseph S. Myers
2011-11-07 17:24 ` Andrew MacLeod
2011-11-07 17:43 ` Hans-Peter Nilsson
2011-11-07 18:27 ` Andrew MacLeod
2011-11-08 6:45 ` Hans-Peter Nilsson
2011-11-08 13:43 ` Andrew MacLeod
2011-11-11 17:49 ` Benjamin Kosnik
2011-11-11 17:56 ` Andrew MacLeod
2011-11-11 21:07 ` Hans-Peter Nilsson
2011-11-11 23:34 ` Torvald Riegel [this message]
2011-11-11 20:27 ` Hans-Peter Nilsson
2011-11-07 16:32 ` Richard Henderson
2011-11-08 20:22 ` Hans-Peter Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321053229.22674.41.camel@triegel.csb \
--to=triegel@redhat.com \
--cc=amacleod@redhat.com \
--cc=bkoz@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hans-peter.nilsson@axis.com \
--cc=joseph@codesourcery.com \
--cc=libstdc++@gcc.gnu.org \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).