From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16500 invoked by alias); 29 Jan 2013 13:05:54 -0000 Received: (qmail 16486 invoked by uid 22791); 29 Jan 2013 13:05:52 -0000 X-SWARE-Spam-Status: No, hits=-7.6 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_SPAMHAUS_DROP,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 29 Jan 2013 13:05:45 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r0TD5ev2019617 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 29 Jan 2013 08:05:40 -0500 Received: from [10.36.4.25] (vpn1-4-25.ams2.redhat.com [10.36.4.25]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id r0TD5c0O027287; Tue, 29 Jan 2013 08:05:39 -0500 Subject: Re: [PATCH] Add faster HTM fastpath for libitm TSX From: Torvald Riegel To: Andi Kleen Cc: gcc-patches@gcc.gnu.org, Andi Kleen , Richard Henderson In-Reply-To: <20130124164504.GE30577@one.firstfloor.org> References: <1358024603-18673-1-git-send-email-andi@firstfloor.org> <1359020523.3101.6165.camel@triegel.csb> <20130124164504.GE30577@one.firstfloor.org> Content-Type: text/plain; charset="UTF-8" Date: Tue, 29 Jan 2013 13:05:00 -0000 Message-ID: <1359464737.3101.12763.camel@triegel.csb> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-01/txt/msg01369.txt.bz2 On Thu, 2013-01-24 at 17:45 +0100, Andi Kleen wrote: > > > > > + uint32_t *__gtm_global_lock; > > > > Same, and rearrange the serial lock's fields (see below). > > My understanding is that C++ makes no guarantees of class layout. > That is why i ended up not relying on the layout. gtm_rwlock is a POD type, so you get the guarantees that C would provide. Torvald