From: Steve Ellcey <steve.ellcey@imgtec.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Aldy Hernandez <aldyh@redhat.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
"rdsandiford@googlemail.com" <rdsandiford@googlemail.com>
Subject: Re: PR target/52555: attribute optimize is overriding command line options
Date: Fri, 22 Feb 2013 17:32:00 -0000 [thread overview]
Message-ID: <1361554314.1732.17.camel@ubuntu-sellcey> (raw)
In-Reply-To: <20130222100311.GJ1215@tucnak.zalov.cz>
On Fri, 2013-02-22 at 11:03 +0100, Jakub Jelinek wrote:
> The problem I believe is that Aldy has changed init_optabs and insn-opinit.c
> to use this_fn_optabs instead of this_target_optabs, but it is only set in
> invoke_set_current_function_hook. During save_target_globals we want to
> init this_target_optabs, so we need to temporarily switch this_fn_optabs to
> make that happen.
>
> 2013-02-22 Jakub Jelinek <jakub@redhat.com>
>
> PR target/52555
> * target-globals.c (save_target_globals): For init_reg_sets and
> target_reinit remporarily set this_fn_optabs to this_target_optabs.
>
Jakub,
I built with this patch and ran the GCC testsuite (using the target
mips-mti-linux-gnu), it fixed the problem and caused no regressions for
me.
Steve Ellcey
sellcey@imgtec.com
next prev parent reply other threads:[~2013-02-22 17:32 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-12 0:15 Aldy Hernandez
2013-02-12 14:05 ` Jakub Jelinek
2013-02-12 15:58 ` Aldy Hernandez
2013-02-12 16:16 ` Jakub Jelinek
2013-02-12 16:30 ` Richard Sandiford
2013-02-12 17:28 ` Aldy Hernandez
2013-02-12 17:48 ` Richard Sandiford
2013-02-12 17:46 ` Richard Sandiford
2013-02-13 17:39 ` Aldy Hernandez
2013-02-13 17:58 ` Richard Sandiford
2013-02-13 18:08 ` Aldy Hernandez
2013-02-13 19:54 ` Jakub Jelinek
2013-02-15 17:23 ` Aldy Hernandez
2013-02-15 17:35 ` Jakub Jelinek
2013-02-15 17:52 ` Aldy Hernandez
2013-02-16 11:20 ` Richard Sandiford
2013-02-18 18:51 ` Aldy Hernandez
2013-02-18 23:05 ` Jakub Jelinek
2013-02-21 23:03 ` Steve Ellcey
2013-02-22 0:10 ` Aldy Hernandez
2013-02-22 10:03 ` Jakub Jelinek
2013-02-22 17:32 ` Steve Ellcey [this message]
2013-02-22 18:17 ` Jakub Jelinek
2013-02-22 19:49 ` Richard Sandiford
2013-03-01 23:37 ` Steve Ellcey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1361554314.1732.17.camel@ubuntu-sellcey \
--to=steve.ellcey@imgtec.com \
--cc=aldyh@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rdsandiford@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).