From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21263 invoked by alias); 22 Feb 2013 17:32:11 -0000 Received: (qmail 21254 invoked by uid 22791); 22 Feb 2013 17:32:09 -0000 X-SWARE-Spam-Status: No, hits=-4.8 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_HOSTKARMA_W,RCVD_IN_HOSTKARMA_WL,RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from multi.imgtec.com (HELO multi.imgtec.com) (194.200.65.239) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 22 Feb 2013 17:32:00 +0000 Subject: Re: PR target/52555: attribute optimize is overriding command line options From: Steve Ellcey To: Jakub Jelinek CC: Aldy Hernandez , gcc-patches , "rdsandiford@googlemail.com" In-Reply-To: <20130222100311.GJ1215@tucnak.zalov.cz> References: <20130218230522.GB1215@tucnak.zalov.cz> <1C0E790D7E4C75418622FD04CC2A1172015D5C06@bamail02.ba.imgtec.org> <20130222100311.GJ1215@tucnak.zalov.cz> Content-Type: text/plain; charset="us-ascii" Date: Fri, 22 Feb 2013 17:32:00 -0000 Message-ID: <1361554314.1732.17.camel@ubuntu-sellcey> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-SEF-Processed: 7_3_0_01181__2013_02_22_17_31_57 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2013-02/txt/msg01078.txt.bz2 On Fri, 2013-02-22 at 11:03 +0100, Jakub Jelinek wrote: > The problem I believe is that Aldy has changed init_optabs and insn-opinit.c > to use this_fn_optabs instead of this_target_optabs, but it is only set in > invoke_set_current_function_hook. During save_target_globals we want to > init this_target_optabs, so we need to temporarily switch this_fn_optabs to > make that happen. > > 2013-02-22 Jakub Jelinek > > PR target/52555 > * target-globals.c (save_target_globals): For init_reg_sets and > target_reinit remporarily set this_fn_optabs to this_target_optabs. > Jakub, I built with this patch and ran the GCC testsuite (using the target mips-mti-linux-gnu), it fixed the problem and caused no regressions for me. Steve Ellcey sellcey@imgtec.com