* [PATCH] Remove unused pass_update_address_taken
@ 2013-06-05 2:48 David Malcolm
2013-06-05 8:33 ` Richard Biener
0 siblings, 1 reply; 3+ messages in thread
From: David Malcolm @ 2013-06-05 2:48 UTC (permalink / raw)
To: gcc-patches
[-- Attachment #1: Type: text/plain, Size: 467 bytes --]
If I'm reading things right, pass_update_address_taken is never actually
used.
Deleting it, I was able to still successfully bootstrap on
x86_64-unknown-linux-gnu (using gcc-4.7.2-2.fc17.x86_64).
The use of the pass appears to have been removed in:
http://gcc.gnu.org/r164525
Should I remove it from trunk?
2013-06-05 David Malcolm <dmalcolm@redhat.com>
* tree-pass.h (pass_update_address_taken): Remove.
* tree-ssa.c (pass_update_address_taken): Remove.
[-- Attachment #2: remove-pass_update_address_taken.patch --]
[-- Type: text/x-patch, Size: 1342 bytes --]
Index: gcc/tree-pass.h
===================================================================
--- gcc/tree-pass.h (revision 199679)
+++ gcc/tree-pass.h (working copy)
@@ -487,7 +487,6 @@
extern struct gimple_opt_pass pass_release_ssa_names;
extern struct gimple_opt_pass pass_early_inline;
extern struct gimple_opt_pass pass_inline_parameters;
-extern struct gimple_opt_pass pass_update_address_taken;
extern struct gimple_opt_pass pass_convert_switch;
/* The root of the compilation pass tree, once constructed. */
Index: gcc/tree-ssa.c
===================================================================
--- gcc/tree-ssa.c (revision 199679)
+++ gcc/tree-ssa.c (working copy)
@@ -2129,23 +2129,3 @@
BITMAP_FREE (suitable_for_renaming);
timevar_pop (TV_ADDRESS_TAKEN);
}
-
-struct gimple_opt_pass pass_update_address_taken =
-{
- {
- GIMPLE_PASS,
- "addressables", /* name */
- OPTGROUP_NONE, /* optinfo_flags */
- NULL, /* gate */
- NULL, /* execute */
- NULL, /* sub */
- NULL, /* next */
- 0, /* static_pass_number */
- TV_ADDRESS_TAKEN, /* tv_id */
- PROP_ssa, /* properties_required */
- 0, /* properties_provided */
- 0, /* properties_destroyed */
- 0, /* todo_flags_start */
- TODO_update_address_taken /* todo_flags_finish */
- }
-};
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove unused pass_update_address_taken
2013-06-05 2:48 [PATCH] Remove unused pass_update_address_taken David Malcolm
@ 2013-06-05 8:33 ` Richard Biener
2013-06-05 9:54 ` David Malcolm
0 siblings, 1 reply; 3+ messages in thread
From: Richard Biener @ 2013-06-05 8:33 UTC (permalink / raw)
To: David Malcolm; +Cc: gcc-patches
On Wed, Jun 5, 2013 at 4:48 AM, David Malcolm <dmalcolm@redhat.com> wrote:
> If I'm reading things right, pass_update_address_taken is never actually
> used.
>
> Deleting it, I was able to still successfully bootstrap on
> x86_64-unknown-linux-gnu (using gcc-4.7.2-2.fc17.x86_64).
>
> The use of the pass appears to have been removed in:
> http://gcc.gnu.org/r164525
>
> Should I remove it from trunk?
I haven't settled for whether the current scheme of using TODOs is really
the best thing yet... (it probably is not). So I'd rather keep the pass
around.
Thanks,
Richard.
> 2013-06-05 David Malcolm <dmalcolm@redhat.com>
>
> * tree-pass.h (pass_update_address_taken): Remove.
> * tree-ssa.c (pass_update_address_taken): Remove.
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Remove unused pass_update_address_taken
2013-06-05 8:33 ` Richard Biener
@ 2013-06-05 9:54 ` David Malcolm
0 siblings, 0 replies; 3+ messages in thread
From: David Malcolm @ 2013-06-05 9:54 UTC (permalink / raw)
To: Richard Biener; +Cc: gcc-patches
On Wed, 2013-06-05 at 10:33 +0200, Richard Biener wrote:
> On Wed, Jun 5, 2013 at 4:48 AM, David Malcolm <dmalcolm@redhat.com> wrote:
> > If I'm reading things right, pass_update_address_taken is never actually
> > used.
> >
> > Deleting it, I was able to still successfully bootstrap on
> > x86_64-unknown-linux-gnu (using gcc-4.7.2-2.fc17.x86_64).
> >
> > The use of the pass appears to have been removed in:
> > http://gcc.gnu.org/r164525
> >
> > Should I remove it from trunk?
>
> I haven't settled for whether the current scheme of using TODOs is really
> the best thing yet... (it probably is not). So I'd rather keep the pass
> around.
Fair enough - thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-05 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-05 2:48 [PATCH] Remove unused pass_update_address_taken David Malcolm
2013-06-05 8:33 ` Richard Biener
2013-06-05 9:54 ` David Malcolm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).