* [PATCH] final.c: make debug_prefix_maps static
@ 2013-06-11 14:57 David Malcolm
2013-06-11 16:34 ` Richard Henderson
0 siblings, 1 reply; 3+ messages in thread
From: David Malcolm @ 2013-06-11 14:57 UTC (permalink / raw)
To: gcc patches
[-- Attachment #1: Type: text/plain, Size: 369 bytes --]
Usage of "debug_prefix_maps" is hidden behind an API, with the only
direct uses of the ptr being within final.c. Indeed the declaration of
its type is local to that file.
Hence it can be made static.
Successfully bootstrapped on x86_64-unknown-linux-gnu
OK for trunk?
2013-06-11 David Malcolm <dmalcolm@redhat.com>
* final.c (debug_prefix_maps): Make static.
[-- Attachment #2: make-debug_prefix_maps-static.patch --]
[-- Type: text/x-patch, Size: 388 bytes --]
Index: gcc/final.c
===================================================================
--- gcc/final.c (revision 199957)
+++ gcc/final.c (working copy)
@@ -1471,7 +1471,7 @@
} debug_prefix_map;
/* Linked list of such structures. */
-debug_prefix_map *debug_prefix_maps;
+static debug_prefix_map *debug_prefix_maps;
/* Record a debug file prefix mapping. ARG is the argument to
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] final.c: make debug_prefix_maps static
2013-06-11 14:57 [PATCH] final.c: make debug_prefix_maps static David Malcolm
@ 2013-06-11 16:34 ` Richard Henderson
2013-06-11 17:18 ` David Malcolm
0 siblings, 1 reply; 3+ messages in thread
From: Richard Henderson @ 2013-06-11 16:34 UTC (permalink / raw)
To: David Malcolm; +Cc: gcc patches
On 06/11/2013 07:57 AM, David Malcolm wrote:
> Usage of "debug_prefix_maps" is hidden behind an API, with the only
> direct uses of the ptr being within final.c. Indeed the declaration of
> its type is local to that file.
>
> Hence it can be made static.
>
> Successfully bootstrapped on x86_64-unknown-linux-gnu
>
> OK for trunk?
>
> 2013-06-11 David Malcolm <dmalcolm@redhat.com>
>
> * final.c (debug_prefix_maps): Make static.
>
Ok.
r~
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] final.c: make debug_prefix_maps static
2013-06-11 16:34 ` Richard Henderson
@ 2013-06-11 17:18 ` David Malcolm
0 siblings, 0 replies; 3+ messages in thread
From: David Malcolm @ 2013-06-11 17:18 UTC (permalink / raw)
To: Richard Henderson; +Cc: gcc patches
On Tue, 2013-06-11 at 09:34 -0700, Richard Henderson wrote:
> On 06/11/2013 07:57 AM, David Malcolm wrote:
> > Usage of "debug_prefix_maps" is hidden behind an API, with the only
> > direct uses of the ptr being within final.c. Indeed the declaration of
> > its type is local to that file.
> >
> > Hence it can be made static.
> >
> > Successfully bootstrapped on x86_64-unknown-linux-gnu
> >
> > OK for trunk?
> >
> > 2013-06-11 David Malcolm <dmalcolm@redhat.com>
> >
> > * final.c (debug_prefix_maps): Make static.
> >
>
> Ok.
Thanks; committed to svn trunk as r199963.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-11 17:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-11 14:57 [PATCH] final.c: make debug_prefix_maps static David Malcolm
2013-06-11 16:34 ` Richard Henderson
2013-06-11 17:18 ` David Malcolm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).