From: Tom Tromey <tromey@redhat.com>
To: gcc-patches@gcc.gnu.org
Cc: Tom Tromey <tromey@redhat.com>
Subject: [PATCH v2 03/18] move generated_files order-only dependency later
Date: Mon, 29 Jul 2013 16:25:00 -0000 [thread overview]
Message-ID: <1375115069-31143-4-git-send-email-tromey@redhat.com> (raw)
In-Reply-To: <1375115069-31143-1-git-send-email-tromey@redhat.com>
There is an order-only dependency in gcc/Makefile.in that tries to
build the generated files before compiling regular objects. However,
this appears too early, and so at the time it is seen by make,
GCOV_OBJS and GCOV_DUMP_OBJS have not yet been set.
This patch fixes the problem and prevents any future problems of this
nature by moving the order-only dependency to the end of Makefile.in.
This also adds lto-wrapper.o to ALL_HOST_BACKEND_OBJS.
* Makefile.in (ALL_HOST_BACKEND_OBJS): Add lto-wrapper.o.
($(ALL_HOST_OBJS)): Move order-only dependency to end
of file.
---
gcc/Makefile.in | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index f13ea01..6ba2e93 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -1493,7 +1493,8 @@ ALL_HOST_FRONTEND_OBJS = $(foreach v,$(CONFIG_LANGUAGES),$($(v)_OBJS))
ALL_HOST_BACKEND_OBJS = $(GCC_OBJS) $(OBJS) $(OBJS-libcommon) \
$(OBJS-libcommon-target) @TREEBROWSER@ main.o c-family/cppspec.o \
- $(COLLECT2_OBJS) $(EXTRA_GCC_OBJS) $(GCOV_OBJS) $(GCOV_DUMP_OBJS)
+ $(COLLECT2_OBJS) $(EXTRA_GCC_OBJS) $(GCOV_OBJS) $(GCOV_DUMP_OBJS) \
+ lto-wrapper.o
# This lists all host object files, whether they are included in this
# compilation or not.
@@ -3860,11 +3861,6 @@ generated_files = config.h tm.h $(TM_P_H) $(TM_H) multilib.h \
options.h target-hooks-def.h insn-opinit.h \
common/common-target-hooks-def.h
-# In order for parallel make to really start compiling the expensive
-# objects from $(OBJS) as early as possible, build all their
-# prerequisites strictly before all objects.
-$(ALL_HOST_OBJS) : | $(generated_files)
-
#\f
# How to compile object files to run on the build machine.
@@ -5357,3 +5353,8 @@ po/gcc.pot: force
$(MAKE) srcextra
AWK=$(AWK) $(SHELL) $(srcdir)/po/exgettext \
$(XGETTEXT) gcc $(srcdir)
+
+# In order for parallel make to really start compiling the expensive
+# objects from $(OBJS) as early as possible, build all their
+# prerequisites strictly before all objects.
+$(ALL_HOST_OBJS) : | $(generated_files)
--
1.8.1.4
next prev parent reply other threads:[~2013-07-29 16:24 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 16:24 [PATCH v2 00/18] resurrect automatic dependencies Tom Tromey
2013-07-29 16:24 ` [PATCH v2 11/18] convert the Fortran front end to " Tom Tromey
2013-07-29 16:24 ` [PATCH v2 10/18] Fix up c-family targets Tom Tromey
2013-07-29 16:24 ` [PATCH v2 17/18] remove last definition of CROSS_FLOAT_H Tom Tromey
2013-07-29 16:24 ` [PATCH v2 13/18] convert LTO to automatic dependencies Tom Tromey
2013-07-29 16:24 ` [PATCH v2 08/18] convert the ObjC++ front end " Tom Tromey
2013-07-29 16:40 ` Mike Stump
2013-07-29 16:53 ` Tom Tromey
2013-07-29 16:24 ` [PATCH v2 12/18] convert the Go " Tom Tromey
2013-07-29 16:25 ` [PATCH v2 01/18] clean up SHLIB so subshells are not needed Tom Tromey
2013-07-29 16:25 ` [PATCH v2 04/18] add configury Tom Tromey
2013-07-29 16:25 ` Tom Tromey [this message]
2013-07-29 16:25 ` [PATCH v2 07/18] convert the ObjC front end to automatic dependencies Tom Tromey
2013-07-29 16:42 ` Mike Stump
2013-07-29 16:25 ` [PATCH v2 18/18] remove unused macros Tom Tromey
2013-07-29 16:25 ` [PATCH v2 16/18] remove last reference to TREE_GIMPLE_H Tom Tromey
2013-07-29 16:25 ` [PATCH v2 05/18] convert the C front end to automatic dependencies Tom Tromey
2013-07-29 16:25 ` [PATCH v2 14/18] remove explicit dependencies Tom Tromey
2013-07-29 16:25 ` [PATCH v2 06/18] convert the C++ front end to automatic dependencies Tom Tromey
2013-07-30 16:39 ` Gabriel Dos Reis
2013-07-29 16:25 ` [PATCH v2 02/18] update generated_files Tom Tromey
2013-07-29 16:25 ` [PATCH v2 15/18] make out_object_file rule use automatic dependencies Tom Tromey
2013-07-29 16:29 ` [PATCH v2 09/18] convert the Java front end to " Tom Tromey
2013-07-29 17:05 ` [PATCH v2 00/18] resurrect " Mike Stump
2013-08-12 8:46 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1375115069-31143-4-git-send-email-tromey@redhat.com \
--to=tromey@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).