* [AArch64] Fix parameters to vcvtx_high
@ 2013-09-06 15:06 James Greenhalgh
2013-09-16 8:57 ` James Greenhalgh
2013-09-16 9:06 ` Marcus Shawcroft
0 siblings, 2 replies; 3+ messages in thread
From: James Greenhalgh @ 2013-09-06 15:06 UTC (permalink / raw)
To: gcc-patches; +Cc: marcus.shawcroft, richard.earnshaw
[-- Attachment #1: Type: text/plain, Size: 437 bytes --]
Hi,
vcvtx_high_f32_f64 should have two parameters, a float32x2 which
provides the lower half of the target vector, and a float64x2
which will be converted to the higher half of the target vector.
Fix thusly.
Tested with aarch64.exp on aarch64-none-elf.
OK?
Thanks,
James
---
gcc/
2013-09-06 James Greenhalgh <james.greenhalgh@arm.com>
* config/aarch64/arm_neon.h
(vcvtx_high_f32_f64): Fix parameters.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-AArch64-Fix-parameters-to-vcvtx_high.patch --]
[-- Type: text/x-patch; name=0001-AArch64-Fix-parameters-to-vcvtx_high.patch, Size: 612 bytes --]
diff --git a/gcc/config/aarch64/arm_neon.h b/gcc/config/aarch64/arm_neon.h
index 5864f2c..47b45f4 100644
--- a/gcc/config/aarch64/arm_neon.h
+++ b/gcc/config/aarch64/arm_neon.h
@@ -5756,12 +5756,12 @@ vcvtx_f32_f64 (float64x2_t a)
}
__extension__ static __inline float32x4_t __attribute__ ((__always_inline__))
-vcvtx_high_f32_f64 (float64x2_t a)
+vcvtx_high_f32_f64 (float32x2_t a, float64x2_t b)
{
float32x4_t result;
__asm__ ("fcvtxn2 %0.4s,%1.2d"
: "=w"(result)
- : "w"(a)
+ : "w" (b), "0"(a)
: /* No clobbers */);
return result;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [AArch64] Fix parameters to vcvtx_high
2013-09-06 15:06 [AArch64] Fix parameters to vcvtx_high James Greenhalgh
@ 2013-09-16 8:57 ` James Greenhalgh
2013-09-16 9:06 ` Marcus Shawcroft
1 sibling, 0 replies; 3+ messages in thread
From: James Greenhalgh @ 2013-09-16 8:57 UTC (permalink / raw)
To: gcc-patches; +Cc: Marcus Shawcroft, Richard Earnshaw
*ping*
Cheers,
James
On Fri, Sep 06, 2013 at 04:06:08PM +0100, James Greenhalgh wrote:
>
> Hi,
>
> vcvtx_high_f32_f64 should have two parameters, a float32x2 which
> provides the lower half of the target vector, and a float64x2
> which will be converted to the higher half of the target vector.
>
> Fix thusly.
>
> Tested with aarch64.exp on aarch64-none-elf.
>
> OK?
>
> Thanks,
> James
>
> ---
> gcc/
>
> 2013-09-06 James Greenhalgh <james.greenhalgh@arm.com>
>
> * config/aarch64/arm_neon.h
> (vcvtx_high_f32_f64): Fix parameters.
>
> diff --git a/gcc/config/aarch64/arm_neon.h b/gcc/config/aarch64/arm_neon.h
> index 5864f2c..47b45f4 100644
> --- a/gcc/config/aarch64/arm_neon.h
> +++ b/gcc/config/aarch64/arm_neon.h
> @@ -5756,12 +5756,12 @@ vcvtx_f32_f64 (float64x2_t a)
> }
>
> __extension__ static __inline float32x4_t __attribute__ ((__always_inline__))
> -vcvtx_high_f32_f64 (float64x2_t a)
> +vcvtx_high_f32_f64 (float32x2_t a, float64x2_t b)
> {
> float32x4_t result;
> __asm__ ("fcvtxn2 %0.4s,%1.2d"
> : "=w"(result)
> - : "w"(a)
> + : "w" (b), "0"(a)
> : /* No clobbers */);
> return result;
> }
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [AArch64] Fix parameters to vcvtx_high
2013-09-06 15:06 [AArch64] Fix parameters to vcvtx_high James Greenhalgh
2013-09-16 8:57 ` James Greenhalgh
@ 2013-09-16 9:06 ` Marcus Shawcroft
1 sibling, 0 replies; 3+ messages in thread
From: Marcus Shawcroft @ 2013-09-16 9:06 UTC (permalink / raw)
To: James Greenhalgh; +Cc: gcc-patches
On 06/09/13 16:06, James Greenhalgh wrote:
> gcc/
>
> 2013-09-06 James Greenhalgh <james.greenhalgh@arm.com>
>
> * config/aarch64/arm_neon.h
> (vcvtx_high_f32_f64): Fix parameters.
>
OK
/Marcus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-09-16 8:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-06 15:06 [AArch64] Fix parameters to vcvtx_high James Greenhalgh
2013-09-16 8:57 ` James Greenhalgh
2013-09-16 9:06 ` Marcus Shawcroft
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).