From: Bill Schmidt <wschmidt@linux.vnet.ibm.com>
To: gcc-patches@gcc.gnu.org
Cc: dje.gcc@gmail.com
Subject: Re: [PATCH, rs6000] (2/3) Fix widening multiply high/low operations for little endian
Date: Mon, 04 Nov 2013 18:05:00 -0000 [thread overview]
Message-ID: <1383587749.6275.323.camel@gnopaine> (raw)
In-Reply-To: <1383543252.6275.305.camel@gnopaine>
Per Richard S's suggestion, I'm reworking parts 1 and 3 of the patch
set, but this one will remain unchanged and is ready for review.
Thanks,
Bill
On Sun, 2013-11-03 at 23:34 -0600, Bill Schmidt wrote:
> Hi,
>
> This patch fixes the widening multiply high/low operations to work
> correctly in the presence of the first patch of this series, which
> reverses the meanings of multiply even/odd instructions. Here we
> reorder the input operands to the vector merge low/high instructions.
>
> The general rule is that vmrghh(x,y) [BE] = vmrglh(y,x) [LE], and so on;
> that is, we need to reverse the usage of merge high and merge low, and
> also swap their inputs, to obtain the same semantics. In this case we
> are only swapping the inputs, because the reversed usage of high and low
> has already been done for us in the generic handling code for
> VEC_WIDEN_MULT_LO_EXPR.
>
> Bootstrapped and tested with the rest of the patch set on
> powerpc64{,le}-unknown-linux-gnu, with no regressions. Is this ok for
> trunk?
>
> Thanks,
> Bill
>
>
> 2013-11-03 Bill Schmidt <wschmidt@linux.vnet.ibm.com>
>
> * config/rs6000/altivec.md (vec_widen_umult_hi_v16qi): Swap
> arguments to merge instruction for little endian.
> (vec_widen_umult_lo_v16qi): Likewise.
> (vec_widen_smult_hi_v16qi): Likewise.
> (vec_widen_smult_lo_v16qi): Likewise.
> (vec_widen_umult_hi_v8hi): Likewise.
> (vec_widen_umult_lo_v8hi): Likewise.
> (vec_widen_smult_hi_v8hi): Likewise.
> (vec_widen_smult_lo_v8hi): Likewise.
>
>
> Index: gcc/config/rs6000/altivec.md
> ===================================================================
> --- gcc/config/rs6000/altivec.md (revision 204192)
> +++ gcc/config/rs6000/altivec.md (working copy)
> @@ -2185,7 +2235,10 @@
>
> emit_insn (gen_vec_widen_umult_even_v16qi (ve, operands[1], operands[2]));
> emit_insn (gen_vec_widen_umult_odd_v16qi (vo, operands[1], operands[2]));
> - emit_insn (gen_altivec_vmrghh (operands[0], ve, vo));
> + if (BYTES_BIG_ENDIAN)
> + emit_insn (gen_altivec_vmrghh (operands[0], ve, vo));
> + else
> + emit_insn (gen_altivec_vmrghh (operands[0], vo, ve));
> DONE;
> }")
>
> @@ -2202,7 +2255,10 @@
>
> emit_insn (gen_vec_widen_umult_even_v16qi (ve, operands[1], operands[2]));
> emit_insn (gen_vec_widen_umult_odd_v16qi (vo, operands[1], operands[2]));
> - emit_insn (gen_altivec_vmrglh (operands[0], ve, vo));
> + if (BYTES_BIG_ENDIAN)
> + emit_insn (gen_altivec_vmrglh (operands[0], ve, vo));
> + else
> + emit_insn (gen_altivec_vmrglh (operands[0], vo, ve));
> DONE;
> }")
>
> @@ -2219,7 +2275,10 @@
>
> emit_insn (gen_vec_widen_smult_even_v16qi (ve, operands[1], operands[2]));
> emit_insn (gen_vec_widen_smult_odd_v16qi (vo, operands[1], operands[2]));
> - emit_insn (gen_altivec_vmrghh (operands[0], ve, vo));
> + if (BYTES_BIG_ENDIAN)
> + emit_insn (gen_altivec_vmrghh (operands[0], ve, vo));
> + else
> + emit_insn (gen_altivec_vmrghh (operands[0], vo, ve));
> DONE;
> }")
>
> @@ -2236,7 +2295,10 @@
>
> emit_insn (gen_vec_widen_smult_even_v16qi (ve, operands[1], operands[2]));
> emit_insn (gen_vec_widen_smult_odd_v16qi (vo, operands[1], operands[2]));
> - emit_insn (gen_altivec_vmrglh (operands[0], ve, vo));
> + if (BYTES_BIG_ENDIAN)
> + emit_insn (gen_altivec_vmrglh (operands[0], ve, vo));
> + else
> + emit_insn (gen_altivec_vmrglh (operands[0], vo, ve));
> DONE;
> }")
>
> @@ -2253,7 +2315,10 @@
>
> emit_insn (gen_vec_widen_umult_even_v8hi (ve, operands[1], operands[2]));
> emit_insn (gen_vec_widen_umult_odd_v8hi (vo, operands[1], operands[2]));
> - emit_insn (gen_altivec_vmrghw (operands[0], ve, vo));
> + if (BYTES_BIG_ENDIAN)
> + emit_insn (gen_altivec_vmrghw (operands[0], ve, vo));
> + else
> + emit_insn (gen_altivec_vmrghw (operands[0], vo, ve));
> DONE;
> }")
>
> @@ -2270,7 +2335,10 @@
>
> emit_insn (gen_vec_widen_umult_even_v8hi (ve, operands[1], operands[2]));
> emit_insn (gen_vec_widen_umult_odd_v8hi (vo, operands[1], operands[2]));
> - emit_insn (gen_altivec_vmrglw (operands[0], ve, vo));
> + if (BYTES_BIG_ENDIAN)
> + emit_insn (gen_altivec_vmrglw (operands[0], ve, vo));
> + else
> + emit_insn (gen_altivec_vmrglw (operands[0], vo, ve));
> DONE;
> }")
>
> @@ -2287,7 +2355,10 @@
>
> emit_insn (gen_vec_widen_smult_even_v8hi (ve, operands[1], operands[2]));
> emit_insn (gen_vec_widen_smult_odd_v8hi (vo, operands[1], operands[2]));
> - emit_insn (gen_altivec_vmrghw (operands[0], ve, vo));
> + if (BYTES_BIG_ENDIAN)
> + emit_insn (gen_altivec_vmrghw (operands[0], ve, vo));
> + else
> + emit_insn (gen_altivec_vmrghw (operands[0], vo, ve));
> DONE;
> }")
>
> @@ -2304,7 +2375,10 @@
>
> emit_insn (gen_vec_widen_smult_even_v8hi (ve, operands[1], operands[2]));
> emit_insn (gen_vec_widen_smult_odd_v8hi (vo, operands[1], operands[2]));
> - emit_insn (gen_altivec_vmrglw (operands[0], ve, vo));
> + if (BYTES_BIG_ENDIAN)
> + emit_insn (gen_altivec_vmrglw (operands[0], ve, vo));
> + else
> + emit_insn (gen_altivec_vmrglw (operands[0], vo, ve));
> DONE;
> }")
>
>
>
next prev parent reply other threads:[~2013-11-04 17:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-04 5:34 Bill Schmidt
2013-11-04 18:05 ` Bill Schmidt [this message]
2013-11-04 19:44 ` David Edelsohn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1383587749.6275.323.camel@gnopaine \
--to=wschmidt@linux.vnet.ibm.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).