From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 3943A3858D32 for ; Mon, 22 Aug 2022 09:39:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3943A3858D32 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=fail smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 45C58339ED; Mon, 22 Aug 2022 09:39:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1661161172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I7QBL1QAyyTn2MfQYxB0QRhN/qJtZCKztLG0KhqpJFY=; b=AKmXuyDdR5hLkRa19kOGiQGoZoxhr7Tt46BUfY+yMSLwB4clVXBNEsJZTbYmsQMcRxVV5W xdJ8dq6vQBcqx+RVWXAaa19D5PbPSJNNl+VR1GgkndUm8bc9VVlv11uWFs0o2kT6dX+mcf ALKAxdKNlOKOXWwPjSJun71BwaDkJSA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1661161172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=I7QBL1QAyyTn2MfQYxB0QRhN/qJtZCKztLG0KhqpJFY=; b=uKgVUsQWAcZuZjnTbqN4iMHbvk9T44ChE3QjcpxIPvKv6smnXyL0YA2wCJpk/pp+fsdzLe dYGPdR0e9ytWLYBg== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 31B1013523; Mon, 22 Aug 2022 09:39:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id PqbKCtROA2NNdwAAMHmgww (envelope-from ); Mon, 22 Aug 2022 09:39:32 +0000 Message-ID: <13847bc4-00e8-1680-da3c-4c95b33ce1be@suse.cz> Date: Mon, 22 Aug 2022 11:39:31 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.1.2 Subject: Re: [committed] Fix more problems with new linker warnings Content-Language: en-US To: Jeff Law , 'GCC Patches' References: <16a40e11-e97f-59bd-9990-9b7e6dee39c9@gmail.com> From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: <16a40e11-e97f-59bd-9990-9b7e6dee39c9@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, SPF_HELO_NONE, SPF_SOFTFAIL, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Aug 2022 09:39:34 -0000 On 4/28/22 18:10, Jeff Law via Gcc-patches wrote: > As I mentioned in the original thread, my change to pr94157_0 was an attempt to avoid these warnings by passing a magic flag to the linker.  Of course we may not be using GNU ld.  Or we may be on a non-elf target where the flag I used doesn't exist.  Or we may even be on a ELF target where those bits weren't added to the linker (frv).  Furthermore, we need fixes to all the nested function tests as well. > > So even though I initially resisted pruning the warning, that seems like the best course of action.  So this patch removes my recent change to pr94157_0 and instead uses our pruning facilities. > > I'll be pushing this to the trunk and gcc-12 branch. > > Jeff Hello. I noticed this patch during my GCC test-suite run with mold linker. As you likely now, the linker defaults to non-executable stack and so one sees test-suite crashes (not only warnings) [1]. So the question is if we want to explicitly fix all tests that rely on exectack? Or is it something we can assume as it's what GNU linkers do? List of affected tests: https://gist.githubusercontent.com/marxin/aadb75408a5a7867bf9fb26e879ce4c4/raw/aff2a0e4559e2dba8ea358520ca836eda6e7dc70/gistfile1.txt Thanks, Martin [1] https://github.com/rui314/mold/issues/427