From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18118 invoked by alias); 19 Nov 2013 15:52:37 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18109 invoked by uid 89); 19 Nov 2013 15:52:37 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 19 Nov 2013 15:52:35 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAJFqRTK007658 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 19 Nov 2013 10:52:27 -0500 Received: from [10.3.227.208] (vpn-227-208.phx2.redhat.com [10.3.227.208]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAJFqRUP022769; Tue, 19 Nov 2013 10:52:27 -0500 Message-ID: <1384876315.11568.114.camel@surprise> Subject: Re: [PATCH] Updated automated patch (was Re: [PATCH 3/6] Automated part of conversion of gimple types to use C++ inheritance) From: David Malcolm To: Jeff Law Cc: gcc-patches@gcc.gnu.org, Andrew MacLeod Date: Tue, 19 Nov 2013 16:36:00 -0000 In-Reply-To: <528AF38A.7080909@redhat.com> References: <5271CBF9.2070005@redhat.com> <1383236801-13234-1-git-send-email-dmalcolm@redhat.com> <1383236801-13234-4-git-send-email-dmalcolm@redhat.com> <5284806A.2050607@redhat.com> <1384806352.11568.80.camel@surprise> <528AF38A.7080909@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg02336.txt.bz2 On Mon, 2013-11-18 at 22:13 -0700, Jeff Law wrote: > On 11/18/13 13:25, David Malcolm wrote: > > > > I regenerated it and am bootstrapping now. I glanced over it and > > nothing major seems to have changed; just changes due to the movement of > > code between files. Am attaching the changed patch. > Yea, there's a lot of churn right now, so this is kind-of expected. > > Thanks for re-posting and verifying it's good to go. Never hurts to be > careful. > > > > > I think so, yes, though you'll have to cast it to the appropriate > > subclass by hand; rather than the status quo of getting multiple > > screenfuls of text, you'll just get the gimple_statement_base fields: > Right. It's parsing the pages of text that I find to be a totally > pointless waste of time. It's gotten worse, mostly because I was away > for too long and I don't have the accessors in muscle-memory. > > WRT elimination of the GIMPLE_CHECKs, understood on the state of things > and why the script didn't eliminate them in the various places I pointed > out. > > This is fine. Please install. Thanks; I've committed the combined patch series to trunk as r205034.