From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16722 invoked by alias); 22 Nov 2013 00:33:12 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 16696 invoked by uid 89); 22 Nov 2013 00:33:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.8 required=5.0 tests=AWL,BAYES_50,RDNS_NONE,SPF_HELO_PASS,SPF_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from Unknown (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 22 Nov 2013 00:33:10 +0000 Received: from int-mx02.intmail.prod.int.phx2.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id rAM0X3QT007100 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Thu, 21 Nov 2013 19:33:03 -0500 Received: from [10.3.228.59] (vpn-228-59.phx2.redhat.com [10.3.228.59]) by int-mx02.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id rAM0X2mx017892; Thu, 21 Nov 2013 19:33:02 -0500 Message-ID: <1385080349.11568.233.camel@surprise> Subject: Re: [PATCH] Updated automated patch (was Re: [PATCH 3/6] Automated part of conversion of gimple types to use C++ inheritance) From: David Malcolm To: Andrew MacLeod Cc: Jakub Jelinek , Jeff Law , gcc-patches@gcc.gnu.org Date: Fri, 22 Nov 2013 03:48:00 -0000 In-Reply-To: <528E9135.7060408@redhat.com> References: <5271CBF9.2070005@redhat.com> <1383236801-13234-1-git-send-email-dmalcolm@redhat.com> <1383236801-13234-4-git-send-email-dmalcolm@redhat.com> <5284806A.2050607@redhat.com> <1384806352.11568.80.camel@surprise> <20131121221933.GQ892@tucnak.redhat.com> <528E8837.5080300@redhat.com> <20131121224257.GR892@tucnak.redhat.com> <528E9135.7060408@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2013-11/txt/msg02804.txt.bz2 On Thu, 2013-11-21 at 18:03 -0500, Andrew MacLeod wrote: > On 11/21/2013 05:42 PM, Jakub Jelinek wrote: > > On Thu, Nov 21, 2013 at 03:24:55PM -0700, Jeff Law wrote: > >> On 11/21/13 15:19, Jakub Jelinek wrote: > >>> On Mon, Nov 18, 2013 at 03:25:52PM -0500, David Malcolm wrote: > >>>>> So is there some reason the GIMPLE_CHECK was left in here rather than > >>>>> doing the downcasting? This happens in other places. > >>> Note that the changes removed tons of checks that IMHO were desirable. > >>> The as_a that replaced those checks e.g. allows 3 different gimple codes, > >>> while previously only one was allowed, this is both more expensive for > >>> --enable-checking=yes, and allows one to use inline wrappers e.g. > >>> gimple_omp_parallel_something on GIMPLE_OMP_TASK etc. > >> Can you give a couple examples, please? > > I mean e.g. > > gimple_omp_parallel_{,set_}{clauses,child_fn,data_arg}{,_ptr} > > gimple_omp_taskreg_{,set_}{clauses,child_fn,data_arg}{,_ptr} > > gimple_omp_target_{,set_}{clauses,child_fn,data_arg}{,_ptr} > > gimple_omp_teams_{,set_}clauses{,_ptr} > > gimple_omp_return_{,set_}lhs{,_ptr} > > gimple_omp_atomic_store_{,set_}val{,_ptr} > > gimple_resx_{,set_}region > > gimple_eh_dispatch_{,set_}region > > > > Jakub > Why does is_a_helper ::test allow > anything other than a GIMPLE_OMP_PARALLEL..? That seems wrong to me. > should just be the one check. > > gimple_omp_taskreg and other routines "sharing" that helper should have > their own helper and only check the one code.. thats is whole point to > remain at least codegen neutral in these cases and provide correct > checking. The fact that they may happen to share the same underlying > structure is irrelevant. > > I also think this is wrong. This was a bug in my script. Sorry. Working on a fix.