From: Peter Bergner <bergner@vnet.ibm.com>
To: Uros Bizjak <ubizjak@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Richard Biener <richard.guenther@gmail.com>,
Jakub Jelinek <jakub@redhat.com>,
Vladimir Makarov <vmakarov@redhat.com>,
Richard Henderson <rth@redhat.com>,
Jan Hubicka <hubicka@ucw.cz>
Subject: Re: : [PATCH, reginfo.c, i386.c] Backport fix for PR58139 to 4.8
Date: Thu, 16 Jan 2014 12:40:00 -0000 [thread overview]
Message-ID: <1389875985.5729.779.camel@otta> (raw)
In-Reply-To: <CAFULd4aWP9d8SvyKk5dB4S_D2bfxAmwUwRXjb0sP3TYtrjtidg@mail.gmail.com>
On Thu, 2014-01-16 at 09:11 +0100, Uros Bizjak wrote:
> On Wed, Jan 15, 2014 at 2:19 PM, Peter Bergner <bergner@vnet.ibm.com> wrote:
> > Backport from mainline
> > 2013-09-06 Jan Hubicka <jh@suse.cz>
> >
> > * config/i386/i386.c (ix86_hard_regno_mode_ok): AVX modes are valid
> > only when AVX is enabled.
>
> OK for x86, with slight update, as suggested below.
>
> > Index: gcc/config/i386/i386.c
> > ===================================================================
> > --- gcc/config/i386/i386.c (revision 206582)
> > +++ gcc/config/i386/i386.c (working copy)
> > @@ -33944,7 +33944,7 @@ ix86_hard_regno_mode_ok (int regno, enum
> > are available. OImode move is available only when AVX is
> > enabled. */
> > return ((TARGET_AVX && mode == OImode)
> > - || VALID_AVX256_REG_MODE (mode)
> > + || (TARGET_AVX && VALID_AVX256_REG_MODE (mode))
>
> Please use VALID_AVX256_REG_OR_IO_MODE define:
We were already testing for OImode, so do you want me to
remove the redundant compare and make the code look like
the following instead?
Peter
Index: i386.c
===================================================================
--- i386.c (revision 206582)
+++ i386.c (working copy)
@@ -33943,8 +33943,7 @@ ix86_hard_regno_mode_ok (int regno, enum
out of SSE registers, even when no operation instructions
are available. OImode move is available only when AVX is
enabled. */
- return ((TARGET_AVX && mode == OImode)
- || VALID_AVX256_REG_MODE (mode)
+ return ((TARGET_AVX && VALID_AVX256_REG_OR_OI_MODE (mode))
|| VALID_SSE_REG_MODE (mode)
|| VALID_SSE2_REG_MODE (mode)
|| VALID_MMX_REG_MODE (mode)
next prev parent reply other threads:[~2014-01-16 12:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-15 13:20 Peter Bergner
2014-01-16 8:11 ` : " Uros Bizjak
2014-01-16 12:40 ` Peter Bergner [this message]
2014-01-16 12:49 ` Uros Bizjak
2014-01-16 14:58 ` Peter Bergner
-- strict thread matches above, loose matches on Subject: below --
2014-01-14 17:22 Peter Bergner
2014-01-14 19:13 ` Vladimir Makarov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1389875985.5729.779.camel@otta \
--to=bergner@vnet.ibm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=jakub@redhat.com \
--cc=richard.guenther@gmail.com \
--cc=rth@redhat.com \
--cc=ubizjak@gmail.com \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).