* [PATCH] configure, jit: Allow for 'make check-gcc-jit'.
@ 2021-08-17 18:59 Iain Sandoe
2021-08-17 20:53 ` David Malcolm
0 siblings, 1 reply; 5+ messages in thread
From: Iain Sandoe @ 2021-08-17 18:59 UTC (permalink / raw)
To: GCC Patches
Hi,
For those of us who habitually build Ada, it’s convenient to
have a way of running individual test suites without invoking
the acats tests…
being able to do “make check-gcc-jit” from the top level is very
useful when debugging jit testsuite issues.
one can do "cd gcc ; make check-jit "- but this doesn’t seem 100%
identical since the invocations from the top level set the host
exports first.
… the patch itself is trivial / obvious - I am just curious as to
whether there was a reason for omitting it so far?
If not,
OK for master?
thanks
Iain
====
This is a convenience feature that allows the user to
do "make check-gcc-jit" at the top level of the build
to check that facility in isolation from others.
Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
ChangeLog:
* Makefile.def: Add a jit check target for the jit
language.
* Makefile.in: Regenerate.
---
Makefile.def | 1 +
Makefile.in | 8 ++++++++
2 files changed, 9 insertions(+)
diff --git a/Makefile.def b/Makefile.def
index fbfdb6fee08..7cbeca5b181 100644
--- a/Makefile.def
+++ b/Makefile.def
@@ -654,6 +654,7 @@ languages = { language=go; gcc-check-target=check-go;
lib-check-target=check-gotools; };
languages = { language=d; gcc-check-target=check-d;
lib-check-target=check-target-libphobos; };
+languages = { language=jit; gcc-check-target=check-jit; };
// Toplevel bootstrap
bootstrap_stage = { id=1 ; };
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] configure, jit: Allow for 'make check-gcc-jit'.
2021-08-17 18:59 [PATCH] configure, jit: Allow for 'make check-gcc-jit' Iain Sandoe
@ 2021-08-17 20:53 ` David Malcolm
2021-08-27 13:00 ` [PING] " Iain Sandoe
0 siblings, 1 reply; 5+ messages in thread
From: David Malcolm @ 2021-08-17 20:53 UTC (permalink / raw)
To: Iain Sandoe, GCC Patches
On Tue, 2021-08-17 at 19:59 +0100, Iain Sandoe wrote:
> Hi,
>
> For those of us who habitually build Ada, it’s convenient to
> have a way of running individual test suites without invoking
> the acats tests…
>
> being able to do “make check-gcc-jit” from the top level is very
> useful when debugging jit testsuite issues.
>
> one can do "cd gcc ; make check-jit "- but this doesn’t seem 100%
> identical since the invocations from the top level set the host
> exports first.
>
> … the patch itself is trivial / obvious - I am just curious as to
> whether there was a reason for omitting it so far?
Probably just a mistake on my part; Makefile glue is not my strongest
skill.
>
> If not,
>
> OK for master?
Sounds OK to me - but then again, Makefile glue is not my strongest
skill, so not sure if I'm qualified to approve this.
>
> thanks
> Iain
>
> ====
>
>
> This is a convenience feature that allows the user to
> do "make check-gcc-jit" at the top level of the build
> to check that facility in isolation from others.
>
> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>
> ChangeLog:
>
> * Makefile.def: Add a jit check target for the jit
> language.
> * Makefile.in: Regenerate.
> ---
> Makefile.def | 1 +
> Makefile.in | 8 ++++++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/Makefile.def b/Makefile.def
> index fbfdb6fee08..7cbeca5b181 100644
> --- a/Makefile.def
> +++ b/Makefile.def
> @@ -654,6 +654,7 @@ languages = { language=go; gcc-check-
> target=check-go;
> lib-check-target=check-gotools; };
> languages = { language=d; gcc-check-target=check-d;
> lib-check-target=check-target-
> libphobos; };
> +languages = { language=jit; gcc-check-target=check-jit; };
>
> // Toplevel bootstrap
> bootstrap_stage = { id=1 ; };
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PING] Re: [PATCH] configure, jit: Allow for 'make check-gcc-jit'.
2021-08-17 20:53 ` David Malcolm
@ 2021-08-27 13:00 ` Iain Sandoe
2021-09-15 19:28 ` [PING^2] " Iain Sandoe
0 siblings, 1 reply; 5+ messages in thread
From: Iain Sandoe @ 2021-08-27 13:00 UTC (permalink / raw)
To: Jeff Law; +Cc: GCC Patches, David Malcolm
+Jeff
(it’s probably borderline obvious - but in the top level Makefile .. so)
> On 17 Aug 2021, at 21:53, David Malcolm <dmalcolm@redhat.com> wrote:
>
> On Tue, 2021-08-17 at 19:59 +0100, Iain Sandoe wrote:
>> Hi,
>>
>> For those of us who habitually build Ada, it’s convenient to
>> have a way of running individual test suites without invoking
>> the acats tests…
>>
>> being able to do “make check-gcc-jit” from the top level is very
>> useful when debugging jit testsuite issues.
>>
>> one can do "cd gcc ; make check-jit "- but this doesn’t seem 100%
>> identical since the invocations from the top level set the host
>> exports first.
>>
>> … the patch itself is trivial / obvious - I am just curious as to
>> whether there was a reason for omitting it so far?
>
> Probably just a mistake on my part; Makefile glue is not my strongest
> skill.
>
>>
>> If not,
>>
>> OK for master?
>
> Sounds OK to me - but then again, Makefile glue is not my strongest
> skill, so not sure if I'm qualified to approve this.
>
>>
>> thanks
>> Iain
>>
>> ====
>>
>>
>> This is a convenience feature that allows the user to
>> do "make check-gcc-jit" at the top level of the build
>> to check that facility in isolation from others.
>>
>> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>>
>> ChangeLog:
>>
>> * Makefile.def: Add a jit check target for the jit
>> language.
>> * Makefile.in: Regenerate.
>> ---
>> Makefile.def | 1 +
>> Makefile.in | 8 ++++++++
>> 2 files changed, 9 insertions(+)
>>
>> diff --git a/Makefile.def b/Makefile.def
>> index fbfdb6fee08..7cbeca5b181 100644
>> --- a/Makefile.def
>> +++ b/Makefile.def
>> @@ -654,6 +654,7 @@ languages = { language=go; gcc-check-
>> target=check-go;
>> lib-check-target=check-gotools; };
>> languages = { language=d; gcc-check-target=check-d;
>> lib-check-target=check-target-
>> libphobos; };
>> +languages = { language=jit; gcc-check-target=check-jit; };
>>
>> // Toplevel bootstrap
>> bootstrap_stage = { id=1 ; };
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PING^2] [PATCH] configure, jit: Allow for 'make check-gcc-jit'.
2021-08-27 13:00 ` [PING] " Iain Sandoe
@ 2021-09-15 19:28 ` Iain Sandoe
2021-09-17 3:09 ` Jeff Law
0 siblings, 1 reply; 5+ messages in thread
From: Iain Sandoe @ 2021-09-15 19:28 UTC (permalink / raw)
To: GCC Patches
Hi folks,
> On 27 Aug 2021, at 14:00, Iain Sandoe <iain@sandoe.co.uk> wrote:
>
> +Jeff
>
> (it’s probably borderline obvious - but in the top level Makefile .. so)
>
>> On 17 Aug 2021, at 21:53, David Malcolm <dmalcolm@redhat.com> wrote:
>>
>> On Tue, 2021-08-17 at 19:59 +0100, Iain Sandoe wrote:
>>> Hi,
>>>
>>> For those of us who habitually build Ada, it’s convenient to
>>> have a way of running individual test suites without invoking
>>> the acats tests…
>>>
>>> being able to do “make check-gcc-jit” from the top level is very
>>> useful when debugging jit testsuite issues.
>>>
>>> one can do "cd gcc ; make check-jit "- but this doesn’t seem 100%
>>> identical since the invocations from the top level set the host
>>> exports first.
>>>
>>> … the patch itself is trivial / obvious - I am just curious as to
>>> whether there was a reason for omitting it so far?
>>
>> Probably just a mistake on my part; Makefile glue is not my strongest
>> skill.
>>
>>>
>>> If not,
>>>
>>> OK for master?
>>
>> Sounds OK to me - but then again, Makefile glue is not my strongest
>> skill, so not sure if I'm qualified to approve this.
>>
>>>
>>> thanks
>>> Iain
>>>
>>> ====
>>>
>>>
>>> This is a convenience feature that allows the user to
>>> do "make check-gcc-jit" at the top level of the build
>>> to check that facility in isolation from others.
>>>
>>> Signed-off-by: Iain Sandoe <iain@sandoe.co.uk>
>>>
>>> ChangeLog:
>>>
>>> * Makefile.def: Add a jit check target for the jit
>>> language.
>>> * Makefile.in: Regenerate.
>>> ---
>>> Makefile.def | 1 +
>>> Makefile.in | 8 ++++++++
>>> 2 files changed, 9 insertions(+)
>>>
>>> diff --git a/Makefile.def b/Makefile.def
>>> index fbfdb6fee08..7cbeca5b181 100644
>>> --- a/Makefile.def
>>> +++ b/Makefile.def
>>> @@ -654,6 +654,7 @@ languages = { language=go; gcc-check-
>>> target=check-go;
>>> lib-check-target=check-gotools; };
>>> languages = { language=d; gcc-check-target=check-d;
>>> lib-check-target=check-target-
>>> libphobos; };
>>> +languages = { language=jit; gcc-check-target=check-jit; };
>>>
>>> // Toplevel bootstrap
>>> bootstrap_stage = { id=1 ; };
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PING^2] [PATCH] configure, jit: Allow for 'make check-gcc-jit'.
2021-09-15 19:28 ` [PING^2] " Iain Sandoe
@ 2021-09-17 3:09 ` Jeff Law
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Law @ 2021-09-17 3:09 UTC (permalink / raw)
To: Iain Sandoe, GCC Patches
On 9/15/2021 1:28 PM, Iain Sandoe wrote:
> Hi folks,
>
>> On 27 Aug 2021, at 14:00, Iain Sandoe <iain@sandoe.co.uk> wrote:
>>
>> +Jeff
>>
>> (it’s probably borderline obvious - but in the top level Makefile .. so)
OK. Sorry I didn't look at it before. I largely ignore things like JIT
these days.
Jeff
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-09-17 3:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-17 18:59 [PATCH] configure, jit: Allow for 'make check-gcc-jit' Iain Sandoe
2021-08-17 20:53 ` David Malcolm
2021-08-27 13:00 ` [PING] " Iain Sandoe
2021-09-15 19:28 ` [PING^2] " Iain Sandoe
2021-09-17 3:09 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).