From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id B773B3858D32 for ; Sun, 12 Mar 2023 16:54:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B773B3858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x62f.google.com with SMTP id p20so10503378plw.13 for ; Sun, 12 Mar 2023 09:54:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678640072; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=wSgjuSj+lb+im0EztZcvN79tI1N1ThngJI99+pNu5Zw=; b=ae4w5gwL2unPd1LkWOHhafWchm2HJuMgKCZ0QUpkNiCGEhYH7D2emc3Rp8425yGPED jdGe2yU+z6wmj4QPRD4Y6Ta+vxE2IiEdMPYujHMP7Uy2A/phj7mLR4pblFJkgfIG8tTS wNk6PERidAAh5qqYhLLqwNOht/5XeJDpgQu/+avSfXen7lxa7iSv8b72fK0YFmrS5IWG V2LZFHQ6NJY2S8SIJM/80RjIxef9BsP2Qg57GIrwr+L2IUhs027obrGo+99K05X2beLP VApvw920CMHOPrt1uqo8Crkxj9qhoQjwEC2+fQzSop753qr0D98Mnv/pejsJzuo1W/Mp kCmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678640072; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=wSgjuSj+lb+im0EztZcvN79tI1N1ThngJI99+pNu5Zw=; b=Geb/ajJrW/iXMH15bkfVGwnZe90NkYkjSq3B+41vSmUfFGgVsMzPBaxiN/TiwRZpPm ZcuLreqID9ZqzUcwOg/lvnSx6gaRFPfWo7dP37WXwUVS5Frwzcrf4MLfKp5zzy99xRPk 5ed/feKepVbEWcCl3qGEumemWiHCt4cicFgqyYCAgFvQLyKP95Y8Ci2JNCeJ3F5pCstB xUzlvSFfe9Z4RV9F/L3SPgQNa5hHU7+m6XGPpd4wJvhKauPmEdKUt/ou5Rv+X8qSbw+O bnDPNx57Opy6wz7ZYnvp0fXmtKkqMPaEAvfSZI5zLkFzIyHT/m0nL9v9qZLIMTUBc7/W TaHw== X-Gm-Message-State: AO0yUKW3KyqZfMZMKKUVkVLcsVYSYHhD8ITTOP803hPVssjRT00kAm3+ +kaMeEY3aBcp372q+1MPNJ8= X-Google-Smtp-Source: AK7set9eE/gnfp6znjeAbWZ25+Mv5axc7GDkxEdA6iUzvt2zVEB+nyObP0rxvl9f3AmIifAx63XiQA== X-Received: by 2002:a05:6a20:1448:b0:c7:770a:557f with SMTP id a8-20020a056a20144800b000c7770a557fmr39688821pzi.50.1678640072396; Sun, 12 Mar 2023 09:54:32 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id d7-20020a630e07000000b005038291e5cbsm3057371pgl.35.2023.03.12.09.54.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 12 Mar 2023 09:54:31 -0700 (PDT) Message-ID: <13cd2402-9f9b-ca18-ec4c-49f038b2797d@gmail.com> Date: Sun, 12 Mar 2023 10:54:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [Patch] More LLP64 fixes and __PIC__ values fixes for PE targets Content-Language: en-US To: Jonathan Yong <10walls@gmail.com>, Gcc Patch List , NightStrike References: <8edbefac-5151-9ee8-4f86-439503c3d962@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.9 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 3/11/23 18:54, Jonathan Yong wrote: > On 3/11/23 17:29, Jeff Law wrote: >> >> >> On 2/14/23 03:42, Jonathan Yong via Gcc-patches wrote: >>> Attached patches OK? >>> >>> 0002-gcc-testsuite-gcc.dg-fix-pic-test-case-for-PE-target.patch >>> >>>  From 616e43ac41879040e73a266065874148553cddcc Mon Sep 17 00:00:00 2001 >>> From: Jonathan Yong<10walls@gmail.com> >>> Date: Tue, 14 Feb 2023 10:37:03 +0000 >>> Subject: [PATCH 2/2] gcc/testsuite/gcc.dg: fix pic test case for PE >>> targets >>> >>> gcc/testsuite/ChangeLog: >>> >>>     * pic-2.c: fix expected __PIC__ value. >>>     * pic-3.c: ditto. >>>     * pic-4.c: ditto. >> Please adjust your ChangeLog entries slightly, in particular, please >> capitalize the first letter in each ChangeLog entry.  ie, fix->Fix, >> ditto->Ditto. >> >> Presumably the windows platforms are not always PIC and thus should >> not be handled in a manner similar to MIPS? >> >> Assuming that's the case, then this patch is OK with the trivial >> ChangeLog fixes. >> >> > > Windows code is effectively always PIC, since the PE loader can relocate > it anywhere if the preferred address is already occupied. Patch still OK? Yes, still OK. Just make the trivial ChangeLog adjustments. Thanks, jeff