public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
To: Richard Henderson <richard.henderson@linaro.org>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: Richard Earnshaw <Richard.Earnshaw@arm.com>,
	Richard Sandiford <Richard.Sandiford@arm.com>
Subject: Re: [PATCH v2 0/6] Implement asm flag outputs for arm + aarch64
Date: Thu, 14 Nov 2019 13:13:00 -0000	[thread overview]
Message-ID: <13fff61e-af76-3434-1294-7cd67da94b91@foss.arm.com> (raw)
In-Reply-To: <20191114100716.28827-1-richard.henderson@linaro.org>

Hi Richard,

On 11/14/19 10:07 AM, Richard Henderson wrote:
> I've put the implementation into config/arm/aarch-common.c, so
> that it can be shared between the two targets.  This required
> a little bit of cleanup to the CC modes and constraints to get
> the two targets to match up.
>
> Changes for v2:
>   * Document overflow flags.
>   * Add "hs" and "lo" as aliases of "cs" and "cc".
>   * Add unsigned cmp tests to asm-flag-6.c.
>
> Richard Sandiford has given his ack for the aarch64 side.
> I'm still looking for an ack for the arm side.
>
The arm parts look good to me, there's not too much arm-specific stuff 
that's not shared with aarch64 thankfully.

Thanks,

Kyrill


>
> r~
>
>
> Richard Henderson (6):
>   aarch64: Add "c" constraint
>   arm: Fix the "c" constraint
>   arm: Rename CC_NOOVmode to CC_NZmode
>   arm, aarch64: Add support for __GCC_ASM_FLAG_OUTPUTS__
>   arm: Add testsuite checks for asm-flag
>   aarch64: Add testsuite checks for asm-flag
>
>  gcc/config/arm/aarch-common-protos.h          |   6 +
>  gcc/config/aarch64/aarch64-c.c                |   2 +
>  gcc/config/aarch64/aarch64.c                  |   3 +
>  gcc/config/arm/aarch-common.c                 | 136 +++++++++++++
>  gcc/config/arm/arm-c.c                        |   1 +
>  gcc/config/arm/arm.c                          |  15 +-
>  gcc/testsuite/gcc.target/aarch64/asm-flag-1.c |  35 ++++
>  gcc/testsuite/gcc.target/aarch64/asm-flag-3.c |  38 ++++
>  gcc/testsuite/gcc.target/aarch64/asm-flag-5.c |  30 +++
>  gcc/testsuite/gcc.target/aarch64/asm-flag-6.c |  62 ++++++
>  gcc/testsuite/gcc.target/arm/asm-flag-1.c     |  36 ++++
>  gcc/testsuite/gcc.target/arm/asm-flag-3.c     |  38 ++++
>  gcc/testsuite/gcc.target/arm/asm-flag-5.c     |  30 +++
>  gcc/testsuite/gcc.target/arm/asm-flag-6.c     |  62 ++++++
>  gcc/config/aarch64/constraints.md             |   4 +
>  gcc/config/arm/arm-modes.def                  |   4 +-
>  gcc/config/arm/arm.md                         | 186 +++++++++---------
>  gcc/config/arm/constraints.md                 |   5 +-
>  gcc/config/arm/predicates.md                  |   2 +-
>  gcc/config/arm/thumb1.md                      |   8 +-
>  gcc/config/arm/thumb2.md                      |  34 ++--
>  gcc/doc/extend.texi                           |  39 ++++
>  22 files changed, 651 insertions(+), 125 deletions(-)
>  create mode 100644 gcc/testsuite/gcc.target/aarch64/asm-flag-1.c
>  create mode 100644 gcc/testsuite/gcc.target/aarch64/asm-flag-3.c
>  create mode 100644 gcc/testsuite/gcc.target/aarch64/asm-flag-5.c
>  create mode 100644 gcc/testsuite/gcc.target/aarch64/asm-flag-6.c
>  create mode 100644 gcc/testsuite/gcc.target/arm/asm-flag-1.c
>  create mode 100644 gcc/testsuite/gcc.target/arm/asm-flag-3.c
>  create mode 100644 gcc/testsuite/gcc.target/arm/asm-flag-5.c
>  create mode 100644 gcc/testsuite/gcc.target/arm/asm-flag-6.c
>
> -- 
> 2.17.1
>

  parent reply	other threads:[~2019-11-14 13:08 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-14 10:07 Richard Henderson
2019-11-14 10:07 ` [PATCH v2 4/6] arm, aarch64: Add support for __GCC_ASM_FLAG_OUTPUTS__ Richard Henderson
2019-11-14 14:40   ` Richard Earnshaw (lists)
2019-11-14 15:09     ` Richard Henderson
2019-11-14 15:22       ` Richard Earnshaw (lists)
2019-11-14 14:53   ` Richard Earnshaw (lists)
2019-11-14 15:14     ` Richard Henderson
2019-11-14 10:07 ` [PATCH v2 5/6] arm: Add testsuite checks for asm-flag Richard Henderson
2019-11-14 14:48   ` Richard Earnshaw (lists)
2019-11-18 12:28   ` Christophe Lyon
2019-11-18 13:32     ` Richard Henderson
2019-11-14 10:07 ` [PATCH v2 2/6] arm: Fix the "c" constraint Richard Henderson
2019-11-14 13:08   ` Kyrill Tkachov
2019-11-14 13:36     ` Richard Henderson
2019-11-14 10:07 ` [PATCH v2 3/6] arm: Rename CC_NOOVmode to CC_NZmode Richard Henderson
2019-11-14 14:42   ` Richard Earnshaw (lists)
2019-11-14 10:07 ` [PATCH v2 1/6] aarch64: Add "c" constraint Richard Henderson
2019-11-14 10:12 ` [PATCH v2 6/6] aarch64: Add testsuite checks for asm-flag Richard Henderson
2019-11-18 12:35   ` Christophe Lyon
2019-11-18 20:06     ` Richard Henderson
2019-11-18 21:35       ` Andreas Schwab
2019-11-19  8:38       ` Christophe Lyon
2019-11-19  9:26         ` Richard Henderson
2019-11-19 10:12           ` Christophe Lyon
2019-11-14 13:13 ` Kyrill Tkachov [this message]
2019-11-14 13:57   ` [PATCH v2 0/6] Implement asm flag outputs for arm + aarch64 Richard Henderson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13fff61e-af76-3434-1294-7cd67da94b91@foss.arm.com \
    --to=kyrylo.tkachov@foss.arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=Richard.Sandiford@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).