From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-367663-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 30334 invoked by alias); 16 May 2014 13:40:52 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 30323 invoked by uid 89); 16 May 2014 13:40:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2
X-HELO: mail-la0-f47.google.com
Received: from mail-la0-f47.google.com (HELO mail-la0-f47.google.com) (209.85.215.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Fri, 16 May 2014 13:40:50 +0000
Received: by mail-la0-f47.google.com with SMTP id pn19so1971065lab.34        for <gcc-patches@gcc.gnu.org>; Fri, 16 May 2014 06:40:47 -0700 (PDT)
X-Received: by 10.152.4.39 with SMTP id h7mr12283466lah.12.1400247647017;        Fri, 16 May 2014 06:40:47 -0700 (PDT)
Received: from [192.168.1.4] (178-78-231-178.customers.ownit.se. [178.78.231.178])        by mx.google.com with ESMTPSA id i10sm9595986lah.13.2014.05.16.06.40.45        for <multiple recipients>        (version=SSLv3 cipher=RC4-SHA bits=128/128);        Fri, 16 May 2014 06:40:46 -0700 (PDT)
Message-ID: <1400247645.4830.5.camel@G3620.my.own.domain>
Subject: Re: patch8.diff updated Was: Re: GCC's -fsplit-stack disturbing Mach's vm_allocate
From: Svante Signell <svante.signell@gmail.com>
Reply-To: svante.signell@gmail.com
To: Ian Lance Taylor <iant@google.com>
Cc: Samuel Thibault <samuel.thibault@gnu.org>, Thomas Schwinge	 <thomas@codesourcery.com>, gcc-patches <gcc-patches@gcc.gnu.org>, bug-hurd	 <bug-hurd@gnu.org>, Roland McGrath <roland@hack.frob.com>
Date: Fri, 16 May 2014 13:40:00 -0000
In-Reply-To: <CAKOQZ8xpVSa2V-7uAqmwtVzQj6BxrO-pzQ5FF1XThxBVjc3yEg@mail.gmail.com>
References: <1399018692.8487.7.camel@PackardBell-PC>	 <20140502095753.GC6577@type> <20140502100027.GD6577@type>	 <1399027556.8487.12.camel@PackardBell-PC> <20140502105234.GM6577@type>	 <1399363609.13092.29.camel@G3620.my.own.domain>	 <20140506125157.GH5788@type.bordeaux.inria.fr>	 <1399381520.13092.67.camel@G3620.my.own.domain>	 <20140506130755.GL5788@type.bordeaux.inria.fr>	 <1399382738.13092.70.camel@G3620.my.own.domain>	 <20140506132605.GD1010@type.bordeaux.inria.fr>	 <1399450727.13092.106.camel@G3620.my.own.domain>	 <1400227385.10012.98.camel@G3620.my.own.domain>	 <CAKOQZ8xpVSa2V-7uAqmwtVzQj6BxrO-pzQ5FF1XThxBVjc3yEg@mail.gmail.com>
Content-Type: text/plain; charset="ISO-8859-15"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
X-SW-Source: 2014-05/txt/msg01278.txt.bz2

On Fri, 2014-05-16 at 06:20 -0700, Ian Lance Taylor wrote:
> On Fri, May 16, 2014 at 1:03 AM, Svante Signell
> <svante.signell@gmail.com> wrote:
> >
> > For that part of the patch without it the build on GNU/Hurd fails. On
> > the other hand SYS_FCNTL is not defined for e.g. GNU/Linux either. This
> > is used in gcc-4.9-4.9.0/src/libgo/go/net/fd_unix.go:
> > func dupCloseOnExec(fd int) (newfd int, err error) {
> > if atomic.LoadInt32(&tryDupCloexec) == 1 && syscall.F_DUPFD_CLOEXEC!=0 {
> > r0, _, e1 := syscall.Syscall(syscall.SYS_FCNTL, uintptr(fd),
> > syscall.F_DUPFD_CLOEXEC, 0)
> >
> > It is yet unknown how the build succeeds on Linux without the SYS_FCNTL
> > being defined? Maybe any the conditions above are not met.
> 
> On GNU/Linux SYS_FCNTL is defined by the generated file sysinfo.go,
> because SYS_fcntl is defined by <syscall.h>.

Thanks, then that part of the patch should read:

# Special treatment of _SYS_fcntl for GNU/Hurd
if ! grep '^const _SYS_fcntl' ${OUT} > /dev/null 2>&1; then
  echo "const SYS_FCNTL = 0" >> ${OUT}
fi

Shall I submit a new patch8.diff (or all patches again)?