public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Samuel Bronson <naesten@gmail.com>
To: libstdc++@gcc.gnu.org,	GCC Patches <gcc-patches@gcc.gnu.org>
Cc: Samuel Bronson <naesten@gmail.com>,
	Jonathan Wakely <jwakely@redhat.com>,
	GDB Patches <gdb-patches@sourceware.org>,
	Tom Tromey <tromey@redhat.com>
Subject: [PATCH v2 1/3] Make libstdc++ testsuite work with pre-color GCC versions again
Date: Fri, 11 Jul 2014 02:49:00 -0000	[thread overview]
Message-ID: <1405046899-32639-2-git-send-email-naesten@gmail.com> (raw)
In-Reply-To: <1405046899-32639-1-git-send-email-naesten@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1048 bytes --]


When I try to build & test just libstdc++, or to run the testsuite
from trunk against my installed libstdc++, the testsuite tries to pass
"-fdiagnostics-color=never" to the system GCC, which is too old to
know what that is.

Since I really just want to test a patch for the gdb pretty-printers,
and since evidently my machine is too puny to actually build GCC, this
is a bit problematic.

According to the documentation, setting GCC_COLORS to "" in the
environment should be just as effective, while it clearly can't cause
older GCCs to freak out, so that's just what I've done.

(I've also taken the liberty of swapping the "set ccflags" and "set
cxxflags" lines here so that ccflags doesn't end up with two
"-DLOCALEDIR" flags.)

libstdc++-v3/

	* testsuite/lib/libstdc++.exp (libstdc++_init): Set $GCC_COLORS=""
          instead of insisting that GCC understand -fdiagnostics-color=never

Signed-off-by: Samuel Bronson <naesten@gmail.com>
---
 libstdc++-v3/testsuite/lib/libstdc++.exp | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: v2-0001-Make-libstdc-testsuite-work-with-pre-color-GCC-ve.patch --]
[-- Type: text/x-patch; name="v2-0001-Make-libstdc-testsuite-work-with-pre-color-GCC-ve.patch", Size: 772 bytes --]

diff --git a/libstdc++-v3/testsuite/lib/libstdc++.exp b/libstdc++-v3/testsuite/lib/libstdc++.exp
index d91bed6..0fdfbdc 100644
--- a/libstdc++-v3/testsuite/lib/libstdc++.exp
+++ b/libstdc++-v3/testsuite/lib/libstdc++.exp
@@ -289,9 +289,11 @@ proc libstdc++_init { testfile } {
 
     v3track cxxflags 2
 
+    # Should be as good as -fdiagnostics-color=never, but more compatible
+    setenv GCC_COLORS ""
     # Always use MO files built by this test harness.
-    set cxxflags "-fdiagnostics-color=never $cxxflags -DLOCALEDIR=\".\""
     set ccflags "$cxxflags -DLOCALEDIR=\".\""
+    set cxxflags "$cxxflags -DLOCALEDIR=\".\""
 
     # If a PCH file is available, use it.  We must delay performing
     # this check until $cxx and such have been initialized because we

  reply	other threads:[~2014-07-11  2:49 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1400701554-18062-1-git-send-email-naesten@gmail.com>
2014-07-11  2:48 ` [PATCH v2 0/3] Port libstdc++ pretty printers to Python 3 Samuel Bronson
2014-07-11  2:49   ` Samuel Bronson [this message]
2014-07-11 15:33     ` [PATCH v2 1/3] Make libstdc++ testsuite work with pre-color GCC versions again Jonathan Wakely
2014-07-11  3:00   ` [PATCH v2 2/3] libstdc++ testsuite: Turn off GDB's auto-load, list loaded libs Samuel Bronson
2014-07-11 15:33     ` Jonathan Wakely
2014-07-11  3:22   ` [PATCH v2 3/3] Port libstdc++ pretty-printers to Python 2 + Python 3 Samuel Bronson
2014-07-11  3:45     ` [PATCH v3 " Samuel Bronson
2014-07-11 13:49       ` Jonathan Wakely
2014-07-21 17:06       ` Tom Tromey
2014-07-26  6:33         ` Samuel Bronson
2014-07-30 14:20           ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1405046899-32639-2-git-send-email-naesten@gmail.com \
    --to=naesten@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdb-patches@sourceware.org \
    --cc=jwakely@redhat.com \
    --cc=libstdc++@gcc.gnu.org \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).