From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2097 invoked by alias); 6 Aug 2014 17:44:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1905 invoked by uid 89); 6 Aug 2014 17:44:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.1 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: eggs.gnu.org Received: from eggs.gnu.org (HELO eggs.gnu.org) (208.118.235.92) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Wed, 06 Aug 2014 17:44:53 +0000 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XF4tL-00012m-J8 for gcc-patches@gcc.gnu.org; Wed, 06 Aug 2014 13:20:53 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2140) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XF4tL-00012e-8a for gcc-patches@gcc.gnu.org; Wed, 06 Aug 2014 13:20:47 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s76HJkel028765 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Wed, 6 Aug 2014 13:19:46 -0400 Received: from c64.redhat.com (vpn-239-139.phx2.redhat.com [10.3.239.139]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s76HJ2op030913; Wed, 6 Aug 2014 13:19:46 -0400 From: David Malcolm To: gcc-patches@gcc.gnu.org Cc: David Malcolm Subject: [PATCH 075/236] final.c: Use rtx_insn (also touches output.c and config/arc/arc.c) Date: Wed, 06 Aug 2014 17:45:00 -0000 Message-Id: <1407345815-14551-76-git-send-email-dmalcolm@redhat.com> In-Reply-To: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 209.132.183.28 X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg00699.txt.bz2 In particular, after this patch, the first param passed to the FINAL_PRESCAN_INSN macro is strengthened from rtx to rtx_insn *. gcc/ * output.h (final_scan_insn): Strengthen return type from rtx to rtx_insn *. (final_forward_branch_p): Likewise for param. (current_output_insn): Likewise for this global. * final.c (rtx debug_insn): Likewise for this variable. (current_output_insn): Likewise. (get_attr_length_1): Rename param "insn" to "uncast_insn", adding "insn" back in as an rtx_insn * with a checked cast, so that macro ADJUST_INSN_LENGTH can be passed an rtx_insn * as the first param. (compute_alignments): Strengthen local "label" from rtx to rtx_insn *. (shorten_branches): Rename param from "first" to "uncast_first", introducing a new local rtx_insn * "first" using a checked cast to effectively strengthen "first" from rtx to rtx_insn * without affecting the type signature. Strengthen locals "insn", "seq", "next", "label" from rtx to rtx_insn *. (change_scope): Strengthen param "orig_insn" and local "insn" from rtx to rtx_insn *. (final_start_function): Rename param from "first" to "uncast_first", introducing a new local rtx_insn * "first" using a checked cast to effectively strengthen "first" from rtx to rtx_insn * without affecting the type signature. Strengthen local "insn" from rtx to rtx_insn *. (dump_basic_block_info): Strengthen param "insn" from rtx to rtx_insn *. (final): Rename param from "first" to "uncast_first", introducing a new local rtx_insn * "first" using a checked cast to effectively strengthen "first" from rtx to rtx_insn * without affecting the type signature. Strengthen locals "insn", "next" from rtx to rtx_insn *. (output_alternate_entry_point): Strengthen param "insn" from rtx to rtx_insn *. (call_from_call_insn): Strengthen param "insn" from rtx to rtx_call_insn *. (final_scan_insn): Rename param from "insn" to "uncast_insn", introducing a new local rtx_insn * "insn" using a checked cast to effectively strengthen "insn" from rtx to rtx_insn * without affecting the type signature. Strengthen return type and locals "next", "note", "prev", "new_rtx" from rtx to rtx_insn *. Remove now-redundant checked cast to rtx_insn * from both invocations of debug_hooks->var_location. Convert CALL_P into a dyn_cast, introducing a local "call_insn" for use when invoking call_from_call_insn. (notice_source_line): Strengthen param "insn" from rtx to rtx_insn *. (leaf_function_p): Likewise for local "insn". (final_forward_branch_p): Likewise. (leaf_renumber_regs): Likewise for param "first". (rest_of_clean_state): Likewise for locals "insn" and "next". (collect_fn_hard_reg_usage): Likewise for local "insn". (get_call_fndecl): Likewise for param "insn". (get_call_cgraph_rtl_info): Likewise. (get_call_reg_set_usage): Rename param from "insn" to "uncast_insn", introducing a new local rtx_insn * "insn" using a checked cast to effectively strengthen "insn" from rtx to rtx_insn * without affecting the type signature. * config/arc/arc.c (arc_final_prescan_insn): For now, add checked cast when assigning from param "insn" to current_output_insn. (arc_pad_return): Strengthen local "insn" from rtx to rtx_insn * so that we can assign it back to current_output_insn. --- gcc/config/arc/arc.c | 4 +-- gcc/final.c | 99 ++++++++++++++++++++++++++++------------------------ gcc/output.h | 6 ++-- 3 files changed, 58 insertions(+), 51 deletions(-) diff --git a/gcc/config/arc/arc.c b/gcc/config/arc/arc.c index 3b3e820..c502d10 100644 --- a/gcc/config/arc/arc.c +++ b/gcc/config/arc/arc.c @@ -3944,7 +3944,7 @@ arc_final_prescan_insn (rtx insn, rtx *opvec ATTRIBUTE_UNUSED, current_output_insn = emit_insn_before (gen_nop (), NEXT_INSN (PREV_INSN (insn))); final_scan_insn (current_output_insn, asm_out_file, optimize, 1, NULL); - current_output_insn = insn; + current_output_insn = as_a (insn); } /* Restore extraction data which might have been clobbered by arc_hazard. */ extract_constrain_insn_cached (insn); @@ -8652,7 +8652,7 @@ arc_branch_size_unknown_p (void) void arc_pad_return (void) { - rtx insn = current_output_insn; + rtx_insn *insn = current_output_insn; rtx prev = prev_active_insn (insn); int want_long; diff --git a/gcc/final.c b/gcc/final.c index 1ae2c90..22d75c3 100644 --- a/gcc/final.c +++ b/gcc/final.c @@ -117,8 +117,8 @@ along with GCC; see the file COPYING3. If not see #define SEEN_EMITTED 2 /* Last insn processed by final_scan_insn. */ -static rtx debug_insn; -rtx current_output_insn; +static rtx_insn *debug_insn; +rtx_insn *current_output_insn; /* Line number of last NOTE. */ static int last_linenum; @@ -208,14 +208,14 @@ static bool need_profile_function; static int asm_insn_count (rtx); static void profile_function (FILE *); static void profile_after_prologue (FILE *); -static bool notice_source_line (rtx, bool *); +static bool notice_source_line (rtx_insn *, bool *); static rtx walk_alter_subreg (rtx *, bool *); static void output_asm_name (void); -static void output_alternate_entry_point (FILE *, rtx); +static void output_alternate_entry_point (FILE *, rtx_insn *); static tree get_mem_expr_from_op (rtx, int *); static void output_asm_operand_names (rtx *, int *, int); #ifdef LEAF_REGISTERS -static void leaf_renumber_regs (rtx); +static void leaf_renumber_regs (rtx_insn *); #endif #ifdef HAVE_cc0 static int alter_cond (rtx); @@ -373,8 +373,9 @@ init_insn_lengths (void) get its actual length. Otherwise, use FALLBACK_FN to calculate the length. */ static int -get_attr_length_1 (rtx insn, int (*fallback_fn) (rtx)) +get_attr_length_1 (rtx uncast_insn, int (*fallback_fn) (rtx)) { + rtx_insn *insn = as_a (uncast_insn); rtx body; int i; int length = 0; @@ -710,7 +711,7 @@ compute_alignments (void) fprintf (dump_file, "freq_max: %i\n",freq_max); FOR_EACH_BB_FN (bb, cfun) { - rtx label = BB_HEAD (bb); + rtx_insn *label = BB_HEAD (bb); int fallthru_frequency = 0, branch_frequency = 0, has_fallthru = 0; edge e; edge_iterator ei; @@ -898,15 +899,16 @@ make_pass_compute_alignments (gcc::context *ctxt) slots. */ void -shorten_branches (rtx first) +shorten_branches (rtx uncast_first) { - rtx insn; + rtx_insn *first = as_a_nullable (uncast_first); + rtx_insn *insn; int max_uid; int i; int max_log; int max_skip; #define MAX_CODE_ALIGN 16 - rtx seq; + rtx_insn *seq; int something_changed = 1; char *varying_length; rtx body; @@ -943,7 +945,7 @@ shorten_branches (rtx first) if (LABEL_P (insn)) { - rtx next; + rtx_insn *next; bool next_is_jumptable; /* Merge in alignments computed by compute_alignments. */ @@ -985,7 +987,7 @@ shorten_branches (rtx first) } else if (BARRIER_P (insn)) { - rtx label; + rtx_insn *label; for (label = insn; label && ! INSN_P (label); label = NEXT_INSN (label)) @@ -1230,7 +1232,7 @@ shorten_branches (rtx first) #ifdef CASE_VECTOR_SHORTEN_MODE /* If the mode of a following jump table was changed, we may need to update the alignment of this label. */ - rtx next; + rtx_insn *next; bool next_is_jumptable; next = next_nonnote_insn (insn); @@ -1605,9 +1607,9 @@ choose_inner_scope (tree s1, tree s2) /* Emit lexical block notes needed to change scope from S1 to S2. */ static void -change_scope (rtx orig_insn, tree s1, tree s2) +change_scope (rtx_insn *orig_insn, tree s1, tree s2) { - rtx insn = orig_insn; + rtx_insn *insn = orig_insn; tree com = NULL_TREE; tree ts1 = s1, ts2 = s2; tree s; @@ -1728,9 +1730,10 @@ reemit_insn_block_notes (void) test and compare insns. */ void -final_start_function (rtx first, FILE *file, +final_start_function (rtx uncast_first, FILE *file, int optimize_p ATTRIBUTE_UNUSED) { + rtx_insn *first = as_a_nullable (uncast_first); block_depth = 0; this_is_asm_operands = 0; @@ -1768,11 +1771,11 @@ final_start_function (rtx first, FILE *file, #endif ) { - rtx insn; + rtx_insn *insn; for (insn = first; insn; insn = NEXT_INSN (insn)) if (!NOTE_P (insn)) { - insn = NULL_RTX; + insn = NULL; break; } else if (NOTE_KIND (insn) == NOTE_INSN_BASIC_BLOCK @@ -1783,7 +1786,7 @@ final_start_function (rtx first, FILE *file, continue; else { - insn = NULL_RTX; + insn = NULL; break; } @@ -1909,7 +1912,7 @@ final_end_function (void) output file, and INSN is the instruction being emitted. */ static void -dump_basic_block_info (FILE *file, rtx insn, basic_block *start_to_bb, +dump_basic_block_info (FILE *file, rtx_insn *insn, basic_block *start_to_bb, basic_block *end_to_bb, int bb_map_size, int *bb_seqn) { basic_block bb; @@ -1956,9 +1959,10 @@ dump_basic_block_info (FILE *file, rtx insn, basic_block *start_to_bb, For description of args, see `final_start_function', above. */ void -final (rtx first, FILE *file, int optimize_p) +final (rtx uncast_first, FILE *file, int optimize_p) { - rtx insn, next; + rtx_insn *first = as_a_nullable (uncast_first); + rtx_insn *insn, *next; int seen = 0; /* Used for -dA dump. */ @@ -2069,7 +2073,7 @@ get_insn_template (int code, rtx insn) The case fall-through in this function is intentional. */ static void -output_alternate_entry_point (FILE *file, rtx insn) +output_alternate_entry_point (FILE *file, rtx_insn *insn) { const char *name = LABEL_NAME (insn); @@ -2096,7 +2100,7 @@ output_alternate_entry_point (FILE *file, rtx insn) /* Given a CALL_INSN, find and return the nested CALL. */ static rtx -call_from_call_insn (rtx insn) +call_from_call_insn (rtx_call_insn *insn) { rtx x; gcc_assert (CALL_P (insn)); @@ -2134,14 +2138,16 @@ call_from_call_insn (rtx insn) debug information. We force the emission of a line note after both NOTE_INSN_PROLOGUE_END and NOTE_INSN_FUNCTION_BEG. */ -rtx -final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, +rtx_insn * +final_scan_insn (rtx uncast_insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, int nopeepholes ATTRIBUTE_UNUSED, int *seen) { #ifdef HAVE_cc0 rtx set; #endif - rtx next; + rtx_insn *next; + + rtx_insn *insn = as_a (uncast_insn); insn_counter++; @@ -2343,7 +2349,7 @@ final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, case NOTE_INSN_VAR_LOCATION: case NOTE_INSN_CALL_ARG_LOCATION: if (!DECL_IGNORED_P (current_function_decl)) - debug_hooks->var_location (as_a (insn)); + debug_hooks->var_location (insn); break; default: @@ -2633,7 +2639,7 @@ final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, for (i = 1; i < XVECLEN (body, 0); i++) { rtx insn = XVECEXP (body, 0, i); - rtx next = NEXT_INSN (insn); + rtx_insn *next = NEXT_INSN (insn); /* We loop in case any instruction in a delay slot gets split. */ do @@ -2842,12 +2848,12 @@ final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, if (optimize_p && !flag_no_peephole && !nopeepholes) { - rtx next = peephole (insn); + rtx_insn *next = peephole (insn); /* When peepholing, if there were notes within the peephole, emit them before the peephole. */ if (next != 0 && next != NEXT_INSN (insn)) { - rtx note, prev = PREV_INSN (insn); + rtx_insn *note, *prev = PREV_INSN (insn); for (note = NEXT_INSN (insn); note != next; note = NEXT_INSN (note)) @@ -2927,7 +2933,7 @@ final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, needs to be reinserted. */ if (templ == 0) { - rtx prev; + rtx_insn *prev; gcc_assert (prev_nonnote_insn (insn) == last_ignored_compare); @@ -2950,7 +2956,7 @@ final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, be split. */ if (templ[0] == '#' && templ[1] == '\0') { - rtx new_rtx = try_split (body, insn, 0); + rtx_insn *new_rtx = try_split (body, insn, 0); /* If we didn't split the insn, go away. */ if (new_rtx == insn && PATTERN (new_rtx) == body) @@ -2971,9 +2977,9 @@ final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, && targetm.asm_out.unwind_emit) targetm.asm_out.unwind_emit (asm_out_file, insn); - if (CALL_P (insn)) + if (rtx_call_insn *call_insn = dyn_cast (insn)) { - rtx x = call_from_call_insn (insn); + rtx x = call_from_call_insn (call_insn); x = XEXP (x, 0); if (x && MEM_P (x) && GET_CODE (XEXP (x, 0)) == SYMBOL_REF) { @@ -2984,7 +2990,7 @@ final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, assemble_external (t); } if (!DECL_IGNORED_P (current_function_decl)) - debug_hooks->var_location (as_a (insn)); + debug_hooks->var_location (insn); } /* Output assembler code from the template. */ @@ -3011,7 +3017,7 @@ final_scan_insn (rtx insn, FILE *file, int optimize_p ATTRIBUTE_UNUSED, breakpoint location. */ static bool -notice_source_line (rtx insn, bool *is_stmt) +notice_source_line (rtx_insn *insn, bool *is_stmt) { const char *filename; int linenum; @@ -4256,7 +4262,7 @@ asm_fprintf (FILE *file, const char *p, ...) int leaf_function_p (void) { - rtx insn; + rtx_insn *insn; /* Some back-ends (e.g. s390) want leaf functions to stay leaf functions even if they call mcount. */ @@ -4283,7 +4289,7 @@ leaf_function_p (void) output templates to customary add branch prediction hints. */ int -final_forward_branch_p (rtx insn) +final_forward_branch_p (rtx_insn *insn) { int insn_id, label_id; @@ -4333,9 +4339,9 @@ only_leaf_regs_used (void) available in leaf functions. */ static void -leaf_renumber_regs (rtx first) +leaf_renumber_regs (rtx_insn *first) { - rtx insn; + rtx_insn *insn; /* Renumber only the actual patterns. The reg-notes can contain frame pointer refs, @@ -4584,7 +4590,7 @@ make_pass_shorten_branches (gcc::context *ctxt) static unsigned int rest_of_clean_state (void) { - rtx insn, next; + rtx_insn *insn, *next; FILE *final_output = NULL; int save_unnumbered = flag_dump_unnumbered; int save_noaddr = flag_dump_noaddr; @@ -4751,7 +4757,7 @@ make_pass_clean_state (gcc::context *ctxt) static void collect_fn_hard_reg_usage (void) { - rtx insn; + rtx_insn *insn; #ifdef STACK_REGS int i; #endif @@ -4800,7 +4806,7 @@ collect_fn_hard_reg_usage (void) /* Get the declaration of the function called by INSN. */ static tree -get_call_fndecl (rtx insn) +get_call_fndecl (rtx_insn *insn) { rtx note, datum; @@ -4819,7 +4825,7 @@ get_call_fndecl (rtx insn) call targets that can be overwritten. */ static struct cgraph_rtl_info * -get_call_cgraph_rtl_info (rtx insn) +get_call_cgraph_rtl_info (rtx_insn *insn) { tree fndecl; @@ -4838,9 +4844,10 @@ get_call_cgraph_rtl_info (rtx insn) in REG_SET. Return DEFAULT_SET in REG_SET if not found. */ bool -get_call_reg_set_usage (rtx insn, HARD_REG_SET *reg_set, +get_call_reg_set_usage (rtx uncast_insn, HARD_REG_SET *reg_set, HARD_REG_SET default_set) { + rtx_insn *insn = as_a_nullable (uncast_insn); if (flag_use_caller_save) { struct cgraph_rtl_info *node = get_call_cgraph_rtl_info (insn); diff --git a/gcc/output.h b/gcc/output.h index 53d575a..e4799cf 100644 --- a/gcc/output.h +++ b/gcc/output.h @@ -70,7 +70,7 @@ extern void final (rtx, FILE *, int); /* The final scan for one insn, INSN. Args are same as in `final', except that INSN is the insn being scanned. Value returned is the next insn to be scanned. */ -extern rtx final_scan_insn (rtx, FILE *, int, int, int *); +extern rtx_insn *final_scan_insn (rtx, FILE *, int, int, int *); /* Replace a SUBREG with a REG or a MEM, based on the thing it is a subreg of. */ @@ -136,7 +136,7 @@ extern int leaf_function_p (void); /* Return 1 if branch is a forward branch. Uses insn_shuid array, so it works only in the final pass. May be used by output templates to add branch prediction hints, for example. */ -extern int final_forward_branch_p (rtx); +extern int final_forward_branch_p (rtx_insn *); /* Return 1 if this function uses only the registers that can be safely renumbered. */ @@ -321,7 +321,7 @@ extern const char *weak_global_object_name; extern rtx current_insn_predicate; /* Last insn processed by final_scan_insn. */ -extern rtx current_output_insn; +extern rtx_insn *current_output_insn; /* Nonzero while outputting an `asm' with operands. This means that inconsistencies are the user's fault, so don't die. -- 1.8.5.3