From: Steve Ellcey <sellcey@mips.com>
To: Eric Christopher <echristo@gmail.com>
Cc: "Moore, Catherine" <Catherine_Moore@mentor.com>,
"matthew.fortune@imgtec.com" <matthew.fortune@imgtec.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH mips] Do not compile mips16.S in soft-float mode
Date: Tue, 12 Aug 2014 15:33:00 -0000 [thread overview]
Message-ID: <1407857590.2601.66.camel@ubuntu-sellcey> (raw)
In-Reply-To: <CALehDX4O0Tk7N981UNWPQ0HmLetTo1rkJ2zac=9h40CxS_KWPw@mail.gmail.com>
On Tue, 2014-08-12 at 00:07 -0700, Eric Christopher wrote:
> >>
> >> -#ifdef __mips_micromips
> >> +#if defined(__mips_micromips) || defined(__mips_soft_float)
> >> /* DO NOTHING */
> >> #else
> >>
>
> Mind adding a comment here explaining why we don't want to do anything
> for soft float (and micromips)?
>
> OK otherwise.
>
> Thanks!
>
> -eric
OK, I added this comment to the checkin:
#if defined(__mips_micromips) || defined(__mips_soft_float)
/* Do nothing because this code is only needed when linking
against mips16 hard-float objects. Neither micromips code
nor soft-float code can be linked against mips16 hard-float
objects so we do not need these routines when building libgcc
for those cases. */
Steve Ellcey
sellcey@mips.com
next prev parent reply other threads:[~2014-08-12 15:33 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-08 15:39 Steve Ellcey
2014-08-09 14:49 ` Moore, Catherine
2014-08-12 7:08 ` Eric Christopher
2014-08-12 15:33 ` Steve Ellcey [this message]
2014-08-12 18:04 ` Eric Christopher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1407857590.2601.66.camel@ubuntu-sellcey \
--to=sellcey@mips.com \
--cc=Catherine_Moore@mentor.com \
--cc=echristo@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=matthew.fortune@imgtec.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).