From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 2998 invoked by alias); 19 Aug 2014 17:52:25 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 2988 invoked by uid 89); 19 Aug 2014 17:52:24 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Aug 2014 17:52:23 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7JHqLEE015363 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 19 Aug 2014 13:52:21 -0400 Received: from bordewijk.wildebeest.org (ovpn-116-30.ams2.redhat.com [10.36.116.30]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7JHqK4n010543 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 19 Aug 2014 13:52:21 -0400 Received: by bordewijk.wildebeest.org (Postfix, from userid 1000) id E83DC8188016; Tue, 19 Aug 2014 19:52:19 +0200 (CEST) Message-ID: <1408470739.3370.16.camel@bordewijk.wildebeest.org> Subject: Re: [PATCH] Add guality [p]type test. From: Mark Wielaard To: Richard Biener Cc: GCC Patches , Jason Merrill , Cary Coutant , Alexandre Oliva , Jakub Jelinek Date: Tue, 19 Aug 2014 17:52:00 -0000 In-Reply-To: References: <1403265071.6147.5.camel@bordewijk.wildebeest.org> <1404381209-11280-1-git-send-email-mjw@redhat.com> <1408446359.3370.12.camel@bordewijk.wildebeest.org> <1408450238.3370.14.camel@bordewijk.wildebeest.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-SW-Source: 2014-08/txt/msg01919.txt.bz2 On Tue, 2014-08-19 at 14:16 +0200, Richard Biener wrote: > On Tue, Aug 19, 2014 at 2:10 PM, Mark Wielaard wrote: > > gcc/testsuite/ChangeLog > > 2014-08-19 Mark Wielaard > > > > * gcc.dg/guality/restrict.c: Add `used' attribute to all variables. > > (cpy): Change type of last argument to int. > > > > That last change is necessary to succeed with LTO. Otherwise the type of > > the function: > > > > static __attribute__((noclone, noinline)) void * > > cpy (void * restrict s1, const void * restrict s2, unsigned int n) > > > > comes out as: > > > > void *(void * restrict, const void * restrict, __unknown__) > > > > That seems a genuine bug. Should I commit the cpy function type change > > to make the test PASS with LTO? Or leave it as is so it FAILs and > > someone else can look into it? >=20 > Yeah, that's a genuine bug. Not sure why it happens. If you file a bug > I can have a look later. Filed as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=3D62190 "LTO DWARF produces __unknown__ type for unsigned int function argument type". I included a smaller testcase in the bug that can just be dropped into gcc/testsuite/gcc.dg/guality/ to show the issue. Shall I just commit the change to the restrict.c testcase, so at least that one always PASSes for now? Cheers, Mark