From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1098 invoked by alias); 19 Aug 2014 19:38:46 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1078 invoked by uid 89); 19 Aug 2014 19:38:46 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 19 Aug 2014 19:38:45 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7JJchv4024746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 19 Aug 2014 15:38:43 -0400 Received: from [10.3.225.110] (vpn-225-110.phx2.redhat.com [10.3.225.110]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7JJcgAG009175; Tue, 19 Aug 2014 15:38:42 -0400 Message-ID: <1408476934.2473.102.camel@surprise> Subject: Re: [PATCH 025/236] make_insn_raw returns an rtx_insn From: David Malcolm To: Jeff Law Cc: gcc-patches@gcc.gnu.org Date: Tue, 19 Aug 2014 19:38:00 -0000 In-Reply-To: <53EAE17A.9080900@redhat.com> References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-26-git-send-email-dmalcolm@redhat.com> <53EAE17A.9080900@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg01935.txt.bz2 On Tue, 2014-08-12 at 21:54 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > Doing so means strengthening the types of the make_raw callbacks within > > emit-rtl.c from rtx to rtx_insn * as used by the emit_pattern_* > > internal functions. There's more that could be done in terms of the > > params to these functions, but we'll save that for later. > > > > gcc/ > > * rtl.h (make_insn_raw): Strengthen return type from rtx to > > rtx_insn *. > > > > * emit-rtl.c (make_insn_raw): Strengthen return type and local > > "insn" from rtx to rtx_insn *. > > (make_debug_insn_raw): Strengthen return type from rtx to > > rtx_insn *; strengthen local "insn" from rtx to rtx_debug_insn *. > > (make_jump_insn_raw): Strengthen return type from rtx to > > rtx_insn *; strengthen local "insn" from rtx to rtx_jump_insn *. > > (make_call_insn_raw): Strengthen return type from rtx to > > rtx_insn *; strengthen local "insn" from rtx to rtx_call_insn *. > > (emit_pattern_before_noloc): Strengthen return type of "make_raw" > > callback from rtx to rtx_insn *; likewise for local "insn" and > > "next", adding a checked cast to rtx_insn in the relevant cases of > > the switch statement. > > (emit_pattern_after_noloc): Strengthen return type of "make_raw" > > callback from rtx to rtx_insn *. > > (emit_pattern_after_setloc): Likewise. > > (emit_pattern_after): Likewise. > > (emit_pattern_before_setloc): Likewise. > > (emit_pattern_before): Likewise. > OK. Thanks. Committed to trunk as r214187.