From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19536 invoked by alias); 20 Aug 2014 10:22:21 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19521 invoked by uid 89); 20 Aug 2014 10:22:20 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 20 Aug 2014 10:22:19 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7KAMHPD002282 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 20 Aug 2014 06:22:17 -0400 Received: from [10.3.225.110] (vpn-225-110.phx2.redhat.com [10.3.225.110]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7KAMGMO003395; Wed, 20 Aug 2014 06:22:16 -0400 Message-ID: <1408529948.2473.139.camel@surprise> Subject: Re: [PATCH 035/236] Return types of unlink_insn_chain and duplicate_insn_chain From: David Malcolm To: Andreas Schwab Cc: gcc-patches@gcc.gnu.org Date: Wed, 20 Aug 2014 10:22:00 -0000 In-Reply-To: References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-36-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg02003.txt.bz2 On Wed, 2014-08-20 at 10:20 +0200, Andreas Schwab wrote: > David Malcolm writes: > > > @@ -4083,7 +4083,7 @@ cfg_layout_can_duplicate_bb_p (const_basic_block bb) > > return true; > > } > > > > -rtx > > +rtx_insn * > > duplicate_insn_chain (rtx from, rtx to) > > { > > rtx insn, next, copy; > > @@ -4169,7 +4169,7 @@ duplicate_insn_chain (rtx from, rtx to) > > } > > insn = NEXT_INSN (last); > > delete_insn (last); > > - return insn; > > + return as_a (insn); > > This is wrong, insn may be NULL. Thanks; and indeed, this broke the bootstrap, as noted in: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01964.html Fixed in r214207: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01971.html Sorry. I'm trying to figure out why this didn't break during my testing. Patch #60 of the original series contained an equivalent as_a -> as_a_nullable hunk: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg00708.html - albeit with a misleading ChangeLog entry (I'm assuming I messed that up during a rebase) - but this hadn't been applied yet. Dave