From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 12926 invoked by alias); 21 Aug 2014 08:21:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 12909 invoked by uid 89); 21 Aug 2014 08:21:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Aug 2014 08:21:42 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7L8Les7028689 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 21 Aug 2014 04:21:40 -0400 Received: from [10.3.225.122] (vpn-225-122.phx2.redhat.com [10.3.225.122]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7L8LdFU030323; Thu, 21 Aug 2014 04:21:39 -0400 Message-ID: <1408609110.2473.163.camel@surprise> Subject: Re: [PATCH 041/236] Debug hooks: use rtx_insn and rtx_code_label From: David Malcolm To: Jeff Law Cc: gcc-patches@gcc.gnu.org Date: Thu, 21 Aug 2014 08:21:00 -0000 In-Reply-To: <53EBA8FE.7070607@redhat.com> References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-42-git-send-email-dmalcolm@redhat.com> <53EBA8FE.7070607@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg02089.txt.bz2 On Wed, 2014-08-13 at 12:05 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > gcc/ > > * debug.h (struct gcc_debug_hooks): Strengthen param 1 of hook > > "label" from rtx to rtx_code_label *. Strengthen param 1 o > > "var_location" hook from rtx to rtx_insn *. > > (debug_nothing_rtx): Delete in favor of... > > (debug_nothing_rtx_code_label): New prototype. > > (debug_nothing_rtx_rtx): Delete unused prototype. > > (debug_nothing_rtx_insn): New prototype. > > > > * final.c (final_scan_insn): Add checked cast to rtx_insn * when > > invoking debug_hooks->var_location (in two places, one in a NOTE > > case of a switch statement, the other guarded by a CALL_P > > conditional. Add checked cast to rtx_code_label * when invoking > > debug_hooks->label (within CODE_LABEL case of switch statement). > > > > * dbxout.c (dbx_debug_hooks): Update "label" hook from > > debug_nothing_rtx to debug_nothing_rtx_code_label. Update > > "var_location" from debug_nothing_rtx to debug_nothing_rtx_insn. > > (xcoff_debug_hooks): Likewise. > > * debug.c (do_nothing_debug_hooks): Likewise. > > (debug_nothing_rtx): Delete in favor of... > > (debug_nothing_rtx_insn): New function. > > (debug_nothing_rtx_rtx): Delete unused function. > > (debug_nothing_rtx_code_label): New function. > > * dwarf2out.c (dwarf2_debug_hooks): Update "label" hook from > > debug_nothing_rtx to debug_nothing_rtx_code_label. > > (dwarf2out_var_location): Strengthen param "loc_note" from rtx > > to rtx_insn *. > > * sdbout.c (sdb_debug_hooks): Update "var_location" hook from > > debug_nothing_rtx to debug_nothing_rtx_insn. > > (sdbout_label): Strengthen param "insn" from rtx to > > rtx_code_label *. > > * vmsdbgout.c (vmsdbg_debug_hooks): Update "label" hook from > > debug_nothing_rtx to debug_nothing_rtx_code_label. Update > > "var_location" hook from debug_nothing_rtx to > > debug_nothing_rtx_insn. > OK. Note minor typo in changelog line #2. "o" at EOL should probably > be "of" Thanks. Bootstrapped; committed to trunk as r214259, with the ChangeLog typo fixed.