From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19372 invoked by alias); 21 Aug 2014 10:14:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19354 invoked by uid 89); 21 Aug 2014 10:14:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 21 Aug 2014 10:14:11 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s7LAE8qL000686 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Thu, 21 Aug 2014 06:14:09 -0400 Received: from [10.3.225.122] (vpn-225-122.phx2.redhat.com [10.3.225.122]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s7LAE8eH004684; Thu, 21 Aug 2014 06:14:08 -0400 Message-ID: <1408615858.2473.166.camel@surprise> Subject: Re: [PATCH 044/236] Pass "insn" as an rtx_insn within generated get_attr_ fns in insn-attrtab.c From: David Malcolm To: Jeff Law Cc: gcc-patches@gcc.gnu.org Date: Thu, 21 Aug 2014 10:14:00 -0000 In-Reply-To: <53EBA951.5090705@redhat.com> References: <1407345815-14551-1-git-send-email-dmalcolm@redhat.com> <1407345815-14551-45-git-send-email-dmalcolm@redhat.com> <53EBA951.5090705@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-08/txt/msg02102.txt.bz2 On Wed, 2014-08-13 at 12:07 -0600, Jeff Law wrote: > On 08/06/14 11:20, David Malcolm wrote: > > Strengthen "insn" from rtx to rtx_insn * within the generated get_attr_ > > functions in insn-attrtab.c, without imposing a strengthening from rtx > > to rtx_insn * on the param itself and thus the callers. > > > > gcc/ > > * genattrtab.c (write_attr_get): Within the generated get_attr_ > > functions, rename param "insn" to "uncast_insn" and reintroduce > > "insn" as an local rtx_insn * using a checked cast, so that "insn" > > is an rtx_insn * within insn-attrtab.c > OK. Thanks; committed to trunk as r214265.