From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 1194 invoked by alias); 5 Sep 2014 01:29:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 1183 invoked by uid 89); 5 Sep 2014 01:29:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 05 Sep 2014 01:29:02 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s851T1sF014816 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL) for ; Thu, 4 Sep 2014 21:29:01 -0400 Received: from [10.3.228.139] (vpn-228-139.phx2.redhat.com [10.3.228.139]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s851T067003702 for ; Thu, 4 Sep 2014 21:29:00 -0400 Message-ID: <1409880338.19403.41.camel@surprise> Subject: [PATCH, committed] Params to modified_between_p From: David Malcolm To: gcc-patches@gcc.gnu.org Date: Fri, 05 Sep 2014 01:29:00 -0000 Content-Type: multipart/mixed; boundary="=-SHCR+gxVgVOQrgMKSK64" Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg00412.txt.bz2 --=-SHCR+gxVgVOQrgMKSK64 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 482 The attached patch strengthens the 2nd and 3rd params of modified_between_p from const_rtx to const rtx_insn * (eliminating a checked cast), and thus falls under the pre-approval granted by Jeff here: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg01310.html Bootstrapped on x86_64-unknown-linux-gnu (Fedora 20), and has been rebuilt as part of a config-list.mk build for all working configurations (albeit with other patches for the latter case). Committed to trunk as r214931. --=-SHCR+gxVgVOQrgMKSK64 Content-Disposition: attachment; filename="r214931.patch" Content-Type: text/x-patch; name="r214931.patch"; charset="UTF-8" Content-Transfer-Encoding: 7bit Content-length: 1826 Index: gcc/rtlanal.c =================================================================== --- gcc/rtlanal.c (revision 214930) +++ gcc/rtlanal.c (revision 214931) @@ -987,10 +987,8 @@ X contains a MEM; this routine does use memory aliasing. */ int -modified_between_p (const_rtx x, const_rtx uncast_start, const_rtx end) +modified_between_p (const_rtx x, const rtx_insn *start, const rtx_insn *end) { - const rtx_insn *start = - safe_as_a (uncast_start); const enum rtx_code code = GET_CODE (x); const char *fmt; int i, j; Index: gcc/ChangeLog =================================================================== --- gcc/ChangeLog (revision 214930) +++ gcc/ChangeLog (revision 214931) @@ -1,5 +1,12 @@ 2014-09-05 David Malcolm + * rtl.h (modified_between_p): Strengthen params 2 and 3 from + const_rtx to const rtx_insn *. + * rtlanal.c (modified_between_p): Likewise, eliminating a checked + cast. + +2014-09-05 David Malcolm + * emit-rtl.c (try_split): Update NULL_RTX to NULL in call to fixup_args_size_notes. * expr.c (fixup_args_size_notes): Strengthen first two params from Index: gcc/rtl.h =================================================================== --- gcc/rtl.h (revision 214930) +++ gcc/rtl.h (revision 214931) @@ -2743,7 +2743,7 @@ extern int reg_set_between_p (const_rtx, const_rtx, const_rtx); extern int commutative_operand_precedence (rtx); extern bool swap_commutative_operands_p (rtx, rtx); -extern int modified_between_p (const_rtx, const_rtx, const_rtx); +extern int modified_between_p (const_rtx, const rtx_insn *, const rtx_insn *); extern int no_labels_between_p (const rtx_insn *, const rtx_insn *); extern int modified_in_p (const_rtx, const_rtx); extern int reg_set_p (const_rtx, const_rtx); --=-SHCR+gxVgVOQrgMKSK64--