From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id 5B88B3858401 for ; Wed, 12 Oct 2022 16:33:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5B88B3858401 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pj1-x1035.google.com with SMTP id b15so15746835pje.1 for ; Wed, 12 Oct 2022 09:33:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=mf6IsZJ1RQmAJ8ZhpniAXSumd7rGpoQeH9hi72rcGxA=; b=XF10yPTIBIeQafnjGSd7Z9sVRBGsFET7Doi+9QCYXgslJhfvW4GymXrTNJqvvXXtT7 ERXUIVo6MG3LS55koB103GwDuw4zz4+junJgokqyDV+VL+y24mkcrNoSSjaClb/9QaWl uFdKI6pB1AYg6BaSzBZzEtg7TJ6v6aYhCu5eZG7O/z/T2yLR+ihRLBr9nYcaV91pVA1B 7WOqxyep7nCR23VfvYbaTTwbOe/4+cwweuwT0c+1nmCMRhZw+MqtgGNBhtRV5BvubIq4 bFNXWIPx7+KbKgg2CnfiJy/ic3H7kXKQGXgnxkuxe0yWuo8hY54XkyHcPbSWiN5RTuH1 6Srg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=mf6IsZJ1RQmAJ8ZhpniAXSumd7rGpoQeH9hi72rcGxA=; b=OyRk/BBVsQ5Vh+CZhmBvYqCOoAwatwZajSgQaRZu3oz9UQOFg7vZyxrQCPLAUvmJW9 msb8mrySCZSULmfYhKwj+kDI735nZiIJwq3LdZ0jKbAYPyI7nas4ZPcfXRF3REvjj9Jy 3psII70dHWD9sH3Z7VFlQPsY7dfX75FEg0Ca1g9r9U1fmraV3X3yAzwHdNSaihSxOdj+ Q6q+0TAZ9qHz9oZSkmMGE79C7rU0/PvXKLUMTGEeFhKbo0qFUsWKnVSa5lJ1TeyofK2i TOkXISx0r/yAET2YpxM2ds0xfa5L4dGi7D/8nRctlT7RTPt2rpxmhSjRf01shglsq8Om /yKQ== X-Gm-Message-State: ACrzQf2NWM/rBFmj3XnkIA07Js0GNmtbV02l68fuKFW6wmYM+Gpq9p6t kR7TivHbMtP5fF3cS5APTyUe31nGa0L3nQ== X-Google-Smtp-Source: AMsMyM7Hsbu9/dp82CNA7SKyFdp+QqS8/9bhflkdG2cQjERbXQA/D8YdaAujX0PqhsHVqa+XAXnuBw== X-Received: by 2002:a17:90a:ca96:b0:20b:6ff:1b2 with SMTP id y22-20020a17090aca9600b0020b06ff01b2mr6148829pjt.228.1665592402651; Wed, 12 Oct 2022 09:33:22 -0700 (PDT) Received: from ?IPV6:2601:681:8600:13d0::f0a? ([2601:681:8600:13d0::f0a]) by smtp.gmail.com with ESMTPSA id r30-20020a63a55e000000b00434abd19eeasm9826424pgu.78.2022.10.12.09.33.21 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Oct 2022 09:33:22 -0700 (PDT) Message-ID: <140bbe62-ef64-d6c5-2142-12da0d377bc9@gmail.com> Date: Wed, 12 Oct 2022 10:33:20 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH] libgcc: Quote variable in Makefile.in Content-Language: en-US To: gcc-patches@gcc.gnu.org References: <20221012115252.1881060-1-jwakely@redhat.com> From: Jeff Law In-Reply-To: <20221012115252.1881060-1-jwakely@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/12/22 05:52, Jonathan Wakely via Gcc-patches wrote: > This isn't very important as the error is harmless, but it's easy to fix > and so is one less thing that might confuse people when looking at build > logs. > > OK for trunk? > > -- >8 -- > > If the xgcc executable has not been built (or has been removed by 'make > clean') then the command to print the multilib dir fails, and so the > MULTIOSDIR variable is empty. That then causes: > /bin/sh: line 0: test: !=: unary operator expected > > We can avoid it by quoting the variable. > > libgcc/ChangeLog: > > * Makefile.in: Quote variable. OK jeff