From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from esa2.mentor.iphmx.com (esa2.mentor.iphmx.com [68.232.141.98]) by sourceware.org (Postfix) with ESMTPS id 2FA7A3858C53 for ; Fri, 25 Aug 2023 16:28:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 2FA7A3858C53 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=codesourcery.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=mentor.com X-IronPort-AV: E=Sophos;i="6.02,201,1688457600"; d="scan'208";a="17194690" Received: from orw-gwy-02-in.mentorg.com ([192.94.38.167]) by esa2.mentor.iphmx.com with ESMTP; 25 Aug 2023 08:28:57 -0800 IronPort-SDR: Iga96w1GYPZuJJ9ESGRNEzRLc2GKKyXQhL3gI0+2W460W/IU9uC+CcTh3T8zAYFE0l+aefT82P cTxX3jDIwRcjm2HxZ1hSVMaHtd8h5T5X7VFc/XBDHCgGC2BJVu63QFW9z3+JGzmInHUuzMPcZf vIq2yZcjJf9bqZ0Fa8wFCF3DoCaJQVDYEbX+Ctxa/dUV9BUoyMoOMUGf1dNzRh4DRXVWb/JD/r eOhtaw1u1mSwtgELoEU7/srL1A0QGRFSLbwTw98WeFwrpCxmIalp54ZdDc2a/OsChT77Iczax2 YnY= Date: Fri, 25 Aug 2023 16:28:53 +0000 From: Joseph Myers To: FX Coudert CC: GCC Patches , Iain Sandoe Subject: Re: Darwin: Replace environment runpath with embedded [PR88590] In-Reply-To: Message-ID: <14111ba7-615b-b2e9-6fba-e7bee3728182@codesourcery.com> References: <92993a50-9667-45da-a62-5089e7e052f8@codesourcery.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="-1152306461-207812524-1692980933=:1281238" X-Originating-IP: [137.202.0.90] X-ClientProxiedBy: svr-ies-mbx-14.mgc.mentorg.com (139.181.222.14) To svr-ies-mbx-10.mgc.mentorg.com (139.181.222.10) X-Spam-Status: No, score=-3104.7 required=5.0 tests=BAYES_00,HEADER_FROM_DIFFERENT_DOMAINS,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: ---1152306461-207812524-1692980933=:1281238 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT On Fri, 25 Aug 2023, FX Coudert via Gcc-patches wrote: > Hi, > > Thanks Joseph for the review. > > > The driver changes are OK. > > > > I think the new configure options and the new -nodefaultrpaths compiler > > option need documenting > > Doc patch was added, and okay’ed by Iain. I see documentation for -nodefaultrpaths; not for configure options, and at least one of the configure options looks like it's being defined as a GCC-specific configure option rather than a libtool one, so should definitely be documented in install.texi. > Attached is the final patchset. Joseph, is your previous OK good for > pushing, or does it need further review? The driver changes are still OK. -- Joseph S. Myers joseph@codesourcery.com ---1152306461-207812524-1692980933=:1281238--