From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 19210 invoked by alias); 29 Sep 2014 15:35:35 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 19200 invoked by uid 89); 29 Sep 2014 15:35:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 29 Sep 2014 15:35:33 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s8TFZRG1021948 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 29 Sep 2014 11:35:27 -0400 Received: from [10.36.5.174] (vpn1-5-174.ams2.redhat.com [10.36.5.174]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s8TFZPGU025738; Mon, 29 Sep 2014 11:35:26 -0400 Subject: Re: [PATCH v3] PR libitm/61164: use always_inline consistently From: Torvald Riegel To: Gleb Fotengauer-Malinovskiy Cc: Jakub Jelinek , Richard Henderson , gcc-patches@gcc.gnu.org In-Reply-To: <20140929125326.GD19878@glebfm.cloud.tilaa.com> References: <20140927120617.GA19658@glebfm.cloud.tilaa.com> <20140927170000.GB19878@glebfm.cloud.tilaa.com> <20140929085415.GB17454@tucnak.redhat.com> <20140929125326.GD19878@glebfm.cloud.tilaa.com> Content-Type: text/plain; charset="UTF-8" Date: Mon, 29 Sep 2014 15:35:00 -0000 Message-ID: <1412004924.22112.124.camel@triegel.csb> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-09/txt/msg02538.txt.bz2 On Mon, 2014-09-29 at 16:53 +0400, Gleb Fotengauer-Malinovskiy wrote: > -#undef __always_inline > -#define __always_inline __attribute__((always_inline)) > +#define __libitm_always_inline inline __attribute__((always_inline)) The previous code seems to work in libstdc++. I believe that eventually, we'll want to use libstdc++-v3/include/bits/atomic_base.h (see the comment at the top of the file). Can we keep the diff between the two files small?