public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Torvald Riegel <triegel@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: Gleb Fotengauer-Malinovskiy <glebfm@altlinux.org>,
	       Richard Henderson <rth@redhat.com>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH v3] PR libitm/61164: use always_inline consistently
Date: Mon, 29 Sep 2014 16:45:00 -0000	[thread overview]
Message-ID: <1412009094.22112.125.camel@triegel.csb> (raw)
In-Reply-To: <20140929153854.GG17454@tucnak.redhat.com>

On Mon, 2014-09-29 at 17:38 +0200, Jakub Jelinek wrote:
> On Mon, Sep 29, 2014 at 05:35:24PM +0200, Torvald Riegel wrote:
> > On Mon, 2014-09-29 at 16:53 +0400, Gleb Fotengauer-Malinovskiy wrote:
> > > -#undef  __always_inline
> > > -#define __always_inline __attribute__((always_inline))
> > > +#define __libitm_always_inline inline __attribute__((always_inline))
> > 
> > The previous code seems to work in libstdc++.  I believe that
> > eventually, we'll want to use libstdc++-v3/include/bits/atomic_base.h
> > (see the comment at the top of the file).  Can we keep the diff between
> > the two files small?
> 
> libstdc++-v3/include/bits/atomic_base.h uses
> _GLIBCXX_ALWAYS_INLINE macro:
> 
> #ifndef _GLIBCXX_ALWAYS_INLINE
> #define _GLIBCXX_ALWAYS_INLINE inline __attribute__((always_inline))
> #endif

Ahh.. I missed that "inline" in there when I had a quick look.  Sorry
for the noise :)

      reply	other threads:[~2014-09-29 16:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-27 12:07 [PATCH] " Gleb Fotengauer-Malinovskiy
2014-09-27 17:00 ` [PATCH v2] " Gleb Fotengauer-Malinovskiy
2014-09-29  8:54   ` Jakub Jelinek
2014-09-29 12:53     ` [PATCH v3] " Gleb Fotengauer-Malinovskiy
2014-09-29 13:38       ` Jakub Jelinek
2014-09-29 16:24         ` [PATCH] PR libitm/61164: redefinition of __always_inline Gleb Fotengauer-Malinovskiy
2014-09-29 15:35       ` [PATCH v3] PR libitm/61164: use always_inline consistently Torvald Riegel
2014-09-29 15:39         ` Jakub Jelinek
2014-09-29 16:45           ` Torvald Riegel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1412009094.22112.125.camel@triegel.csb \
    --to=triegel@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=glebfm@altlinux.org \
    --cc=jakub@redhat.com \
    --cc=rth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).