From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6246 invoked by alias); 6 Oct 2014 02:06:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 6230 invoked by uid 89); 6 Oct 2014 02:06:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.5 required=5.0 tests=AWL,BAYES_00,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e7.ny.us.ibm.com Received: from e7.ny.us.ibm.com (HELO e7.ny.us.ibm.com) (32.97.182.137) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 06 Oct 2014 02:06:49 +0000 Received: from /spool/local by e7.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 5 Oct 2014 22:06:46 -0400 Received: from d01dlp03.pok.ibm.com (9.56.250.168) by e7.ny.us.ibm.com (192.168.1.107) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Sun, 5 Oct 2014 22:06:44 -0400 Received: from b01cxnp22034.gho.pok.ibm.com (b01cxnp22034.gho.pok.ibm.com [9.57.198.24]) by d01dlp03.pok.ibm.com (Postfix) with ESMTP id 8C3FFC9003C for ; Sun, 5 Oct 2014 21:55:28 -0400 (EDT) Received: from d01av04.pok.ibm.com (d01av04.pok.ibm.com [9.56.224.64]) by b01cxnp22034.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id s9626ipO8782306 for ; Mon, 6 Oct 2014 02:06:44 GMT Received: from d01av04.pok.ibm.com (localhost [127.0.0.1]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s9626ith007061 for ; Sun, 5 Oct 2014 22:06:44 -0400 Received: from [9.80.9.80] ([9.80.9.80]) by d01av04.pok.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s9626hAW007038; Sun, 5 Oct 2014 22:06:43 -0400 Message-ID: <1412561203.2986.132.camel@gnopaine> Subject: Re: [PATCH, rs6000] Remove splat calls with out-of-range arguments from gcc.dg/vmx/ops.c From: Bill Schmidt To: David Edelsohn Cc: GCC Patches Date: Mon, 06 Oct 2014 02:06:00 -0000 In-Reply-To: References: <1412011647.2986.7.camel@gnopaine> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14100602-5806-0000-0000-000000AAAFA8 X-IsSubscribed: yes X-SW-Source: 2014-10/txt/msg00405.txt.bz2 By the way, just to follow up on a conversation we had offline: I did a little poking, and found that the assembler objects if any of these out-of-range arguments to vspltb, etc., survive the compiler: /tmp/cctyppYZ.s: Assembler messages: /tmp/cctyppYZ.s:25: Error: operand out of range (-1 is not between 0 and 3) So if the test had been written with dg-do assemble instead of dg-do compile, we would have found the issue long ago. Anyway, I was looking into adding error checking for this in the compiler, but now that seems redundant. Thanks, Bill On Mon, 2014-09-29 at 13:44 -0400, David Edelsohn wrote: > On Mon, Sep 29, 2014 at 1:27 PM, Bill Schmidt > wrote: > > Hi, > > > > While working on another patch, I observed that the test case > > gcc.dg/vmx/ops.c contains numerous calls to vec_splat and friends for > > which the second argument (the element selector) is out of range. At > > best these calls are invalid; as it is, we generate insns that can cause > > trouble during optimization. (In the case I saw, simplify-rtx tried to > > reduce the splat of its input at compile time, but the out-of-range > > element selector caused it to report a bad insn and abort.) This patch > > removes all of the calls with out-of-range element selectors from the > > test case. > > > > Tested on powerpc64le-unknown-linux-gnu. Ok to commit? > > > > Thanks, > > Bill > > > > > > 2014-09-29 Bill Schmidt > > > > * gcc.dg/vmx/ops.c: Remove calls to vec_splat, vec_vsplth, > > vec_vspltw, and vec_vspltb for which the second argument is out of > > range. > > Okay. > > Thanks, David >